GeoTools

NADCONTransform producing warnings when running tests

Details

  • Type: Wish Wish
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 8.0-RC1
  • Fix Version/s: 8.0-RC1
  • Component/s: referencing
  • Labels:
    None

Description

When running tests for PropertyDataStore from Eclipse the console is always opened to show:

May 1, 2012 4:10:37 PM org.geotools.referencing.operation.AuthorityBackedFactory createFromDatabase
WARNING: Failed to create a coordinate operation from "European Petroleum Survey Group" authority factory.
org.opengis.referencing.FactoryException: Could not locate grid file emhpgn.las
	at org.geotools.referencing.operation.transform.NADCONTransform.locateGrid(NADCONTransform.java:248)
	at org.geotools.referencing.operation.transform.NADCONTransform.<init>(NADCONTransform.java:232)
	at org.geotools.referencing.operation.transform.NADCONTransform$Provider.createMathTransform(NADCONTransform.java:640)
	at org.geotools.referencing.operation.DefaultMathTransformFactory.createParameterizedTransform(DefaultMathTransformFactory.java:463)
	at org.geotools.referencing.operation.DefaultMathTransformFactory.createBaseToDerived(DefaultMathTransformFactory.java:352)
	at org.geotools.referencing.factory.epsg.DirectEpsgFactory.createCoordinateOperation(DirectEpsgFactory.java:2727)
	at org.geotools.referencing.factory.BufferedAuthorityFactory.createCoordinateOperation(BufferedAuthorityFactory.java:1041)
	at org.geotools.referencing.factory.epsg.CoordinateOperationSet.createObject(CoordinateOperationSet.java:91)
	at org.geotools.referencing.factory.IdentifiedObjectSet$Iter.toNext(IdentifiedObjectSet.java:394)
	at org.geotools.referencing.factory.IdentifiedObjectSet$Iter.<init>(IdentifiedObjectSet.java:378)
	at org.geotools.referencing.factory.IdentifiedObjectSet.iterator(IdentifiedObjectSet.java:221)
	at org.geotools.referencing.factory.IdentifiedObjectSet.resolve(IdentifiedObjectSet.java:239)
	at org.geotools.referencing.factory.epsg.DirectEpsgFactory.createFromCoordinateReferenceSystemCodes(DirectEpsgFactory.java:2849)
	at org.geotools.referencing.factory.BufferedAuthorityFactory.createFromCoordinateReferenceSystemCodes(BufferedAuthorityFactory.java:1065)
	at org.geotools.referencing.operation.AuthorityBackedFactory.createFromDatabase(AuthorityBackedFactory.java:242)
	at org.geotools.referencing.operation.DefaultCoordinateOperationFactory.tryDB(DefaultCoordinateOperationFactory.java:1562)
	at org.geotools.referencing.operation.DefaultCoordinateOperationFactory.createOperationStep(DefaultCoordinateOperationFactory.java:1006)
	at org.geotools.referencing.operation.DefaultCoordinateOperationFactory.createOperation(DefaultCoordinateOperationFactory.java:286)
	at org.geotools.referencing.operation.BufferedCoordinateOperationFactory.createOperation(BufferedCoordinateOperationFactory.java:256)
	at org.geotools.referencing.CRS.findMathTransform(CRS.java:1150)
	at org.geotools.data.DefaultFeatureResults.<init>(DefaultFeatureResults.java:126)
	at org.geotools.data.AbstractFeatureSource.getFeatures(AbstractFeatureSource.java:219)
	at org.geotools.data.property.PropertyDataStore2Test.testQueryReproject(PropertyDataStore2Test.java:256)

Does this represent a configuration or dependency problem? Or can this warning be asked to relax a little.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Oscar Fonts added a comment -
Also applies for NTv2 transforms.
Not having a grid is a common situation, certainly would be better logged at finer/debug level.
I'll take a look.
Show
Oscar Fonts added a comment - Also applies for NTv2 transforms. Not having a grid is a common situation, certainly would be better logged at finer/debug level. I'll take a look.
Hide
Permalink
Andrea Aime added a comment -
Agreed, we should lower the log statements level
Show
Andrea Aime added a comment - Agreed, we should lower the log statements level
Hide
Permalink
Jody Garnett added a comment -
I have been looking for a place to turn this warning down a notch. Thus far without success.

In reviewing the code DefaultMathTransformFactory is the class doing the calling - and it surrounds the call with the following:

            try {
                parameters = provider.ensureValidValues(parameters);
                transform = provider.createMathTransform(parameters);
            } catch (IllegalArgumentException exception) {
                /*
                 * Catch only exceptions which may be the result of improper parameter
                 * usage (e.g. a value out of range). Do not catch exception caused by
                 * programming errors (e.g. null pointer exception).
                 */
                throw new FactoryException(exception);
            }

Would it be correct to throw an IllegalArgumentException if the parameter values are incorrect? i.e. we cannot find a grid of that name?

Where does the value "emhpgn.las" come from anyways?
Show
Jody Garnett added a comment - I have been looking for a place to turn this warning down a notch. Thus far without success. In reviewing the code DefaultMathTransformFactory is the class doing the calling - and it surrounds the call with the following:             try {                 parameters = provider.ensureValidValues(parameters);                 transform = provider.createMathTransform(parameters);             } catch (IllegalArgumentException exception) {                 /*                  * Catch only exceptions which may be the result of improper parameter                  * usage (e.g. a value out of range). Do not catch exception caused by                  * programming errors (e.g. null pointer exception).                  */                 throw new FactoryException(exception);             } Would it be correct to throw an IllegalArgumentException if the parameter values are incorrect? i.e. we cannot find a grid of that name? Where does the value "emhpgn.las" come from anyways?
Hide
Permalink
Andrea Aime added a comment -
It comes from the official EPSG database, we have an extract of the grid files known to the EPSG database here:
http://docs.geoserver.org/latest/en/user/advanced/crshandling/gridshift.html#nadcon
Show
Andrea Aime added a comment - It comes from the official EPSG database, we have an extract of the grid files known to the EPSG database here: http://docs.geoserver.org/latest/en/user/advanced/crshandling/gridshift.html#nadcon
Hide
Permalink
Andrea Aime added a comment -
Jody, the logging happens in AuthorityBackedFactory.createFromDatabase(...), line 265. I believe that AuthorityBackedFactory.log(final Exception exception, final AuthorityFactory factory) logging level can safely be turned down to "FINE"
Show
Andrea Aime added a comment - Jody, the logging happens in AuthorityBackedFactory.createFromDatabase(...), line 265. I believe that AuthorityBackedFactory.log(final Exception exception, final AuthorityFactory factory) logging level can safely be turned down to "FINE"
Hide
Permalink
Jody Garnett added a comment -
Thanks Andrea that fixed it, committed to trunk as of -r38710
Show
Jody Garnett added a comment - Thanks Andrea that fixed it, committed to trunk as of -r38710

People

  • Assignee:
    Jody Garnett
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: