Properties files don't escape "|"s

Jody Garnett added a comment - 27/Apr/12 1:30 AM I don't really find this patch pretty - I had one pretty solution with a regex: [.-\\]| but it failed to handle a string of the form "|foo" The test cases show it working; and I also added a few extra tests around the handling of "multi-line" values in a property file. We have two solutions in the current code base. One based on a search and replace of "\\n" with "\n" and the second based on supporting lines ending with "\\" as per the property file spec.

Andrea Aime added a comment - 28/Apr/12 4:49 AM Ugh, the patch is full of reformats. Patches should be submitted so that only the actual code changes show up. Please don't reformat the code and/or disable automatic reformats?

Jody Garnett added a comment - 29/Apr/12 6:12 AM - edited That splitIntoText method was mostly rewritten. I have confirmed that the patch does not harm with respect to geoserver build. Proceeding to work on writer.

Jody Garnett added a comment - 01/May/12 9:02 AM Okay I am getting tired of the long testing process. While I can pass tests in GeoTools; geoserver seems troubled for me today (but was not yesterday). The patch is easier to follow and I have separated out the string encode and string decode methods in order to focus on them. I am blocked from making property data store be able to handle any string by reason of the txt.repalce("\\n","\n") statements. With that in the mix I have not been smart enough with regular expressions to undo the damage caused.

Jody Garnett added a comment - 01/May/12 11:05 PM Fixed on trunk -r38699 Full geoserver tests pass; earlier problems were resolved by clearing repository.