DWithin filter does not work from GeoServer when passing units parameter

Andrea Aime added a comment - 27/Apr/12 4:42 AM Looks good, couple of things to fix: * the map better be static * do you actually need to set the srid in the point? If so we have another bug handy, as you should not need to do that

Juan Marin Otero added a comment - 27/Apr/12 9:40 AM Hi Andrea, Thanks for the quick review and comments. Updated patch included.

Andrea Aime added a comment - 27/Apr/12 11:15 AM Juan, looks good, do you have commit access? Oh, one odd thing I've just noticed, we have km and miles, meters... and not feet?

Juan Marin Otero added a comment - 27/Apr/12 11:57 AM - edited Andrea, thanks. I added conversion for units in feet. I don't have commit access

Andrea Aime added a comment - 30/Apr/12 6:48 AM Ok, I'll commit this one for you. Once you have collected 3 to 5 applied patches please ask for commit access on the devel list. I did look a bit into the unit conversion issue now that I have access to a Oracle database... what a mess! :-) First off, the table acting as a reference for the UOM names in Oracle is not the one you cited in the comments, it's MD_SYS.SDO_DIST_UNITS instead, see here: http://docs.oracle.com/html/B10826_01/sdo_operat.htm#i77653 The second thing is... where are the OGC units coming from? I looked around since I remembered OGC calls it "metre", not "meter" or "meters", and it seems that OGC wanted to issue come "UOM dictionary" that was actually never released, or something like that. Someone tried to put one togheter and it's here, but it's not complete: https://www.seegrid.csiro.au/subversion/xmml/OGC/trunk/ExampleInstances/dictionaries/units.xml Looking at the latest Filter spec it seems they are using "m" for meters, which makes some sense given it's also a ISO specification, and as such they are using ISO names, which are the same as the Oracle SDO_UNIT names. However both Filter 1.0 and 1.1 talks about the uom dictionary (but not a specific one, just ... one) and makes this example: <Distance unit=” http://www.uomdict.com/uom.html#meters&#x94;&gt;10&lt;/Distance > Uff... it seems there is no fully shared way to specify distances... it's also interesting to see what other people do, here is the table of units supported by MapServer for example: http://mapserver.org/ogc/filter_encoding.html#units-of-measure DeeGree does not have an official table instead... Anyways, going to extend a bit the conversion table and fix the comment, and let you review my changes

Andrea Aime added a comment - 30/Apr/12 7:06 AM Here is a revised version, more units, more tests. For some reason I don't understand the test for millimeters does not work, but all the others do (against my Oracle XE)

Juan Marin Otero added a comment - 30/Apr/12 7:49 AM Andrea, thanks for reviewing this. Your extended patch looks good, and you are going to love this. On my Oracle setup (11.2.0.1, Enterprise Edition) the test with mm works just fine, I just uncommented that line and run it, no issues. There are quite a bit of differences between the XE version and the current enterprise one, but it comes to a surprise that this might be one of them.

Andrea Aime added a comment - 30/Apr/12 9:17 AM Ah Oracle, always being the difficult one to deal with... All right, will commit the patch as is.

Andrea Aime added a comment - 30/Apr/12 9:25 AM Patch applied on 2.7.x and trunk