GeoTools

Shp publish into postgis datastore with MULTIPOLYGON EMPTY value violates check constraint.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

I have a problem when i try to publish a shp into a postgis store.
The generated table is empty but GS does not shows errors.

Checking the Postgres logging I found the following ERROR: new row for relation "admin_shp_test" violates check constraint "enforce_geotype_the_geom".

These seems to be due to a specific call: INSERT INTO "public"."admin_shp_test" ( "the_geom","ID","AREA","PERIMETER","protezione" ) VALUES (GeomFromText('MULTIPOLYGON EMPTY',32633),0,0.0,0.0,'');

The MULTIPOLYGON EMPTY value produce this error.

Attached the test shape file and the path file to resolve this issue

  2. Text File
    geot-4113.patch
    06/May/12 3:09 PM
    22 kB
    Andrea Aime
  3. Text File
    patch-GEOT-4113.txt
    20/Apr/12 5:28 AM
    10 kB
    Francesco Izzi
  4. Text File
    patch-GEOT-4113.txt
    20/Apr/12 5:20 AM
    9 kB
    Francesco Izzi
  5. Text File
    postgis.patch
    19/Apr/12 4:17 AM
    0.7 kB
    Nazzareno Sileno

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. GEOS-5045 Shp publish into postgis datastore with MULTIPOLYGON EMPTY value violates check constraint.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -
Someone has to also add tests to the junit test harness before this one can be committed.
Show
Andrea Aime added a comment - Someone has to also add tests to the junit test harness before this one can be committed.
Hide
Permalink
Francesco Izzi added a comment -
The new patch contains also junit test
Show
Francesco Izzi added a comment - The new patch contains also junit test
Hide
Permalink
Francesco Izzi added a comment -
Fix typo
Show
Francesco Izzi added a comment - Fix typo
Hide
Permalink
Andrea Aime added a comment -
Nice. This weekend I'll be stuck on intercontinental flights, hopefully I'll be able to reivew and apply in the next weeks.
Show
Andrea Aime added a comment - Nice. This weekend I'll be stuck on intercontinental flights, hopefully I'll be able to reivew and apply in the next weeks.
Hide
Permalink
Francesco Izzi added a comment -
No problem Andrea, Have a nice trip !
Show
Francesco Izzi added a comment - No problem Andrea, Have a nice trip !
Hide
Permalink
Andrea Aime added a comment -
Here is an improved patch that checks all geometry types for proper handling of empty geometries and also adds tests for H2.
Justin, Christian, this might be implemented by other databases, basically anything that uses WKB to trade geometries with the dbms will be affected by the inability to represent empty geometries in WKB.
Show
Andrea Aime added a comment - Here is an improved patch that checks all geometry types for proper handling of empty geometries and also adds tests for H2. Justin, Christian, this might be implemented by other databases, basically anything that uses WKB to trade geometries with the dbms will be affected by the inability to represent empty geometries in WKB.
Hide
Permalink
Andrea Aime added a comment -
Justin, Christian: not saying you have to implement it, but take that into account when reviewing it. Let me know if it's ok to commit.
Show
Andrea Aime added a comment - Justin, Christian: not saying you have to implement it, but take that into account when reviewing it. Let me know if it's ok to commit.
Hide
Permalink
Justin Deoliveira added a comment -
Sounds good to me. One thing that would be nice if a comment is added to the javadoc of the relevant encoding methods, just stating that the dialect needs to take the responsibly to check and handle empty geometries accordingly. +1 on the patch.
Show
Justin Deoliveira added a comment - Sounds good to me. One thing that would be nice if a comment is added to the javadoc of the relevant encoding methods, just stating that the dialect needs to take the responsibly to check and handle empty geometries accordingly. +1 on the patch.
Hide
Permalink
Christian Mueller added a comment -
Same defect on DB2. Andrea, I will commit my fixes and my tests after you closed this issue.
Show
Christian Mueller added a comment - Same defect on DB2. Andrea, I will commit my fixes and my tests after you closed this issue.
Hide
Permalink
Andrea Aime added a comment -
Patch applied on 2.7.x and trunk, with the extra javadoc comment telling implementors to pay attention to empty geometries
Show
Andrea Aime added a comment - Patch applied on 2.7.x and trunk, with the extra javadoc comment telling implementors to pay attention to empty geometries

People

  • Assignee:
    Andrea Aime
    Reporter:
    Nazzareno Sileno
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: