GeoTools

ECQL toCQL for INCLUDE and EXCLUDE Filters

Details

  • Type: Wish Wish
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 8.0-RC1
  • Component/s: imageio-ext-gdal plugin
  • Labels:
    None

Description

When I create a CQL text entry field in uDig - I am left with the following on screen:

1=1

.

This is an unfriendly representation of "INCLUDE".

Since ECQL is already headed off the reservation with respect to following the CQL standard; can we extend our extension to support "INCLUDE" and "EXCLUDE"

The gammer already supports parsing "INCLUDE" and "EXCLUDE"; it is just the encoder that needs a couple of methods changed:

	public static Object buildInclude(Object extraData) {
        StringBuilder output = FilterToTextUtil.asStringBuilder(extraData);
        output.append("INCLUDE");        
        return output;
	}

	public static Object buildExclude(Object extraData) {
        StringBuilder output = FilterToTextUtil.asStringBuilder(extraData);
        output.append("EXCLUDE");        
        return output;
	}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
Okay it looks like this is already supported by the grammar:

  public int JJTINCLUDE_NODE = 27;
  public int JJTEXCLUDE_NODE = 28;

A very small change is needed. The only downside I see here is the break of backwards compatibility with CQL (of course "1=1" is not strictly CQL anyways since the form is strictly "propertyName = 1").

What do you think Maurcio?
Show
Jody Garnett added a comment - Okay it looks like this is already supported by the grammar:   public int JJTINCLUDE_NODE = 27;   public int JJTEXCLUDE_NODE = 28; A very small change is needed. The only downside I see here is the break of backwards compatibility with CQL (of course "1=1" is not strictly CQL anyways since the form is strictly "propertyName = 1"). What do you think Maurcio?
Hide
Permalink
Andrea Aime added a comment -
Hmmm... why is this assigned to the imageio-ext-gdal plugin? I guess the interested party here is Mauricio
Show
Andrea Aime added a comment - Hmmm... why is this assigned to the imageio-ext-gdal plugin? I guess the interested party here is Mauricio
Hide
Permalink
Mauricio Pazos added a comment - - edited
Hi, I am not sure if I understood the problem. Right now, CQL and ECQL support INCLUDE and EXCLUDE, ie:

ECQL.toFilter("INCLUDE");

ECQL.toFilter("EXCLUDE");

cheers
Show
Mauricio Pazos added a comment - - edited Hi, I am not sure if I understood the problem. Right now, CQL and ECQL support INCLUDE and EXCLUDE, ie: ECQL.toFilter("INCLUDE"); ECQL.toFilter("EXCLUDE"); cheers
Hide
Permalink
Jody Garnett added a comment -
have a look at the patch; the test cases show what is being tested.

Namely ECQL.toCQL( Filter.INCLUDE ) --> "INCLUDE"

(Currently it outputs to tautology "1=1" )
Show
Jody Garnett added a comment - have a look at the patch; the test cases show what is being tested. Namely ECQL.toCQL( Filter.INCLUDE ) --> "INCLUDE" (Currently it outputs to tautology "1=1" )
Hide
Permalink
Jody Garnett added a comment -
Commit applied to trunk as of -rr38678

Thanks for the discussion on geotools-devel.
Show
Jody Garnett added a comment - Commit applied to trunk as of -rr38678 Thanks for the discussion on geotools-devel.

People

  • Assignee:
    Jody Garnett
    Reporter:
    Jody Garnett
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: