GeoTools

SLDTransformer generate an invalid exended colorMap attribute

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 8.0-M4
  • Fix Version/s: None
  • Component/s: main
  • Labels:
    None

Description

In find this in SLDTransformer at line 528

if(colorMap.getExtendedColors())

{ atts.addAttribute("", "extended", "extended", "", typeString); }

That generate an invalid exended colorMap attribute returning a String instead of a boolean value.

<sld:ColorMap extended="ramp"> (this is an issue example)

the code fix:

boolean extended = colorMap.getExtendedColors();
if(extended)

{ atts.addAttribute("", "extended", "extended", "", ""+extended); }
  1. Text File
    gt-main-SLDTransformerTest-patch.txt
    20/Apr/12 1:26 AM
    2 kB
    Francesco Izzi
  2. Text File
    patch-gt-main.txt
    17/Apr/12 4:48 AM
    0.9 kB
    Francesco Izzi

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -
Hey Jody, the commit you made misses a test. We have been following a strict practice of adding tests whenever a bug is found to improve quality, don't we care anymore?
Show
Andrea Aime added a comment - Hey Jody, the commit you made misses a test. We have been following a strict practice of adding tests whenever a bug is found to improve quality, don't we care anymore?
Hide
Permalink
Jody Garnett added a comment -
I was collaborating with Izzi on IRC - in order to exactly make this case (he is off to make some test cases for several of the other patches where he was wondering why they had stalled out). He was on hand to verify the fix worked; but yes lets reopen this issue and ask him for a test case.
Show
Jody Garnett added a comment - I was collaborating with Izzi on IRC - in order to exactly make this case (he is off to make some test cases for several of the other patches where he was wondering why they had stalled out). He was on hand to verify the fix worked; but yes lets reopen this issue and ask him for a test case.
Hide
Permalink
Jody Garnett added a comment -
Reopened pending test case
Show
Jody Garnett added a comment - Reopened pending test case
Hide
Permalink
Francesco Izzi added a comment -
Tests added
Show
Francesco Izzi added a comment - Tests added
Hide
Permalink
Andrea Aime added a comment -
Test applied too, thanks
Show
Andrea Aime added a comment - Test applied too, thanks

People

  • Assignee:
    Jody Garnett
    Reporter:
    Francesco Izzi
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: