GeoTools

Fix gt-jdbc-oracle java.lang.IllegalArgumentException: Points of LinearRing do not form a closed linestring

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: jdbc-oracle plugin
  • Labels:
    None

Description

Oracle allows for some tolerances at its geometries that causes errors for LinerRing validation. I trust our oracle geometries to be valid then they come out of the database. This patch will ensure that they are for GeoTools too.

  1. File
    closed_open_linsetring_table.sql
    13/May/12 11:31 PM
    1 kB
    Sirko Schroeder
  2. Text File
    oracle_closed_linestring.patch
    15/Apr/12 8:22 PM
    2 kB
    Sirko Schroeder

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. GEOS-3563 GeoServer does not support Oracle fuzzy tolerance polygons

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -
Thanks for the patch! In order to commit it we need a junit test case.
If you cannot write the test, do you at least have the INSERT statement that will put in Oracle a geometry that's valid to Oracle but not to GeoTools?
Show
Andrea Aime added a comment - Thanks for the patch! In order to commit it we need a junit test case. If you cannot write the test, do you at least have the INSERT statement that will put in Oracle a geometry that's valid to Oracle but not to GeoTools?
Hide
Permalink
Sirko Schroeder added a comment -
Hi Andrea, I don't know how to write a junit test but I have attached the SQL statements for an example.
Show
Sirko Schroeder added a comment - Hi Andrea, I don't know how to write a junit test but I have attached the SQL statements for an example.
Hide
Permalink
Sirko Schroeder added a comment -
Oracle example data.
Show
Sirko Schroeder added a comment - Oracle example data.
Hide
Permalink
Sirko Schroeder added a comment -
bump
Show
Sirko Schroeder added a comment - bump
Hide
Permalink
Andrea Aime added a comment -
Ah, tried to have a look and create a patch with a test, but could not get the test to work (wasting half a Sunday on it), it seems with that sql data the results are coming out correct regardless of whether I apply the patch or not... Of course I cannot use that sql directly, I have to integrate it with the tables we have in the test framework, but still...
Show
Andrea Aime added a comment - Ah, tried to have a look and create a patch with a test, but could not get the test to work (wasting half a Sunday on it), it seems with that sql data the results are coming out correct regardless of whether I apply the patch or not... Of course I cannot use that sql directly, I have to integrate it with the tables we have in the test framework, but still...
Hide
Permalink
Jody Garnett added a comment - - edited
Do you have an example of how far you got Andrea? I would not mind reproducing this issue myself as I am setting up a new test fixture at the moment for SDOTest (and this would be an appropriate thing to test).

I expect that this error is determined by exactly how the SDO_DIM_ARRAY is set up, and probably hard to reproduce.

Aside: We can also have the opposite issue where valid JTS Geometry is below the tolerance threshold (for example a polygon that pinches in to a narrow section, if the narrow section is below the tolerance distance oracle will consider the polygon invalid).
Show
Jody Garnett added a comment - - edited Do you have an example of how far you got Andrea? I would not mind reproducing this issue myself as I am setting up a new test fixture at the moment for SDOTest (and this would be an appropriate thing to test). I expect that this error is determined by exactly how the SDO_DIM_ARRAY is set up, and probably hard to reproduce. Aside: We can also have the opposite issue where valid JTS Geometry is below the tolerance threshold (for example a polygon that pinches in to a narrow section, if the narrow section is below the tolerance distance oracle will consider the polygon invalid).
Hide
Permalink
Andrea Aime added a comment -
Jody, nope, unfortunately I don't have that code anymore...
Show
Andrea Aime added a comment - Jody, nope, unfortunately I don't have that code anymore...
Hide
Permalink
Jody Garnett added a comment -
The recently restored SDOTest does not require tables (it simply uses the connection to generate the correct MDSYS STRUCTS). As such it should represent a light-weight way to test this patch.

Show
Jody Garnett added a comment - The recently restored SDOTest does not require tables (it simply uses the connection to generate the correct MDSYS STRUCTS). As such it should represent a light-weight way to test this patch.

People

  • Assignee:
    Andrea Aime
    Reporter:
    Sirko Schroeder
Vote (0)
Watch (3)

Dates

  • Created:
    Updated: