GeoTools

Build failures in referencing caused by bad File/URL conversions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 8.0-RC1
  • Fix Version/s: None
  • Component/s: referencing
  • Labels:
    None
  • Environment:
    Maven 2 and 3, Oracle JDK 6 32 or 64-bit, under Linux, in a path with spaces.

Description

GEOT-4063 patch committed in r38634 on trunk causes build failures in referencing when built in a path with spaces because of bad File/URL conversions. Code likely does not conform to policy:
http://docs.geotools.org/latest/developer/conventions/code/url.html

Results :

Failed tests: 
  testIsNTv2GridAvailable(org.geotools.referencing.factory.gridshift.NTv2GridShiftFactoryTest)

Tests in error: 
  testTransform(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testGetSourceDimensions(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testGetTargetDimensions(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testGetParameterValues(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testNADCONTransform(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testInverse(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testInverseTransform(org.geotools.referencing.operation.transform.NADCONTransformTest): File does not exist or is unreadable: /home/car605/geoserver/src%20with%20spaces/geotools-trunk/modules/library/referencing/target/test-classes/org/geotools/referencing/factory/gridshift/stpaul.las
  testTransform(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.
  testGetSourceDimensions(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.
  testGetTargetDimensions(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.
  testGetParameterValues(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.
  testInverse(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.
  testInverseTransform(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.
  testNTv2Transform(org.geotools.referencing.operation.transform.NTv2TransformTest): NTv2 Grid File not available.

Tests run: 241, Failures: 1, Errors: 14, Skipped: 5
  1. Text File
    GEOT-4080.patch
    19/Mar/12 12:32 AM
    6 kB
    Ben Caradoc-Davies

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. GEOT-4063 NTv2 grid shift transformation (EPSG:9615)

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ben Caradoc-Davies added a comment -
Oscar,

the full text of the failure on the CSIRO Computational Geoscience buildbot is here:
http://geobuilder.arrc.csiro.au/geoserver/builders/GeoT-java15/builds/6277/steps/shell/logs/stdio
This one is Maven 2 with Java 6 32-bit under Debian. I also see this failure with Maven 3 / Java 6 64-bit under Fedora.

Paths with spaces occur often in Windows deployments, and are also a proxy for internationalised filenames that contain unicode characters. If code fails to process paths with spaces, it will likely also fail in other circumstances that require correct escaping and unescaping of special characters. The established convention (in fact a policy) for GeoTools URL/File conversions is documented here:
http://docs.geotools.org/latest/developer/conventions/code/url.html

Kind regards,
Ben.
Show
Ben Caradoc-Davies added a comment - Oscar, the full text of the failure on the CSIRO Computational Geoscience buildbot is here: http://geobuilder.arrc.csiro.au/geoserver/builders/GeoT-java15/builds/6277/steps/shell/logs/stdio This one is Maven 2 with Java 6 32-bit under Debian. I also see this failure with Maven 3 / Java 6 64-bit under Fedora. Paths with spaces occur often in Windows deployments, and are also a proxy for internationalised filenames that contain unicode characters. If code fails to process paths with spaces, it will likely also fail in other circumstances that require correct escaping and unescaping of special characters. The established convention (in fact a policy) for GeoTools URL/File conversions is documented here: http://docs.geotools.org/latest/developer/conventions/code/url.html Kind regards, Ben.
Hide
Permalink
Ben Caradoc-Davies added a comment -
gt-referencing can't use DataUtilities because it is in gt-main, which already depends on gt-referencing. Adding a dependency on gt-main causes a cyclic reference and build failure.
Show
Ben Caradoc-Davies added a comment - gt-referencing can't use DataUtilities because it is in gt-main, which already depends on gt-referencing. Adding a dependency on gt-main causes a cyclic reference and build failure.
Hide
Permalink
Ben Caradoc-Davies added a comment -
Attached patch fixes the build failure. It includes a new class org.geotools.referencing.factory.gridshift.DataUtilities that includes a copy of the urlToFile method from DataUtilities in gt-main. This is an ugly hack required until the module cyclic dependency problem is resolved.
Show
Ben Caradoc-Davies added a comment - Attached patch fixes the build failure. It includes a new class org.geotools.referencing.factory.gridshift.DataUtilities that includes a copy of the urlToFile method from DataUtilities in gt-main. This is an ugly hack required until the module cyclic dependency problem is resolved.
Hide
Permalink
Ben Caradoc-Davies added a comment -
From #geotools on freenode:
<jgarnett> (what is referencing doing accessing a file - I thought it was pure math :-) )
Show
Ben Caradoc-Davies added a comment - From #geotools on freenode: <jgarnett> (what is referencing doing accessing a file - I thought it was pure math :-) )
Hide
Permalink
Andrea Aime added a comment -
I will pretend I haven't seen the last comment....
Show
Andrea Aime added a comment - I will pretend I haven't seen the last comment....
Hide
Permalink
Ben Caradoc-Davies added a comment -
Sorry, couldn't resist. It was a quotable quote.

The problem with elegant mathematical software is that at some point you have to spoil it by getting data in and out. :-)
Show
Ben Caradoc-Davies added a comment - Sorry, couldn't resist. It was a quotable quote. The problem with elegant mathematical software is that at some point you have to spoil it by getting data in and out. :-)
Hide
Permalink
Andrea Aime added a comment -
Patch looks good, please apply.
Show
Andrea Aime added a comment - Patch looks good, please apply.
Hide
Permalink
Ben Caradoc-Davies added a comment -
Thanks Andrea. Committed on trunk in r38635.
Show
Ben Caradoc-Davies added a comment - Thanks Andrea. Committed on trunk in r38635.
Hide
Permalink
Andrea Aime added a comment -
Hudson build went fine, closing
Show
Andrea Aime added a comment - Hudson build went fine, closing

People

  • Assignee:
    Andrea Aime
    Reporter:
    Ben Caradoc-Davies
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: