GeoTools

OracleNGDataStoreFactoryTest fails because it does not use common fixture

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 8.0-RC1
  • Fix Version/s: None
  • Component/s: jdbc-oracle plugin
  • Labels:
    None

Description

When ~/.geotools/oracle.properties is configured to allow other gt-jdbc-oracle online tests to pass, OracleNGDataStoreFactoryTest still fails because is uses its own fixture configuration properties file factory.properties. This file is read from src/test/resources. Attached patch removes redundant fixture configuration files and makes the test use the same file as the others.

(1) Does this test still test whatever it was meant to test?

(2) Is this test still required, or should it instead be removed in its entirety?

  1. Text File
    GEOT-4047.patch
    15/Feb/12 11:53 PM
    2 kB
    Ben Caradoc-Davies

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GEOT-3146 Example online fixtures generated by jdbc-postgis / jdbc-oracle have wrong key for password

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Ben Caradoc-Davies made changes -
Field Original Value New Value
Attachment GEOT-4047.patch [ 58882 ]
Ben Caradoc-Davies made changes -
Description When ~/.geotools/oracle.properties is configured to allow other gt-jdbc-oracle online tests to pass, OracleNGDataStoreFactoryTest still fails because is uses its own fixture configuration properties file factory.properties. This file is read from src/test/resources. Attached patch removes redundant fixture configuration files and makes the test use the same file as the others.

(1) Does this test still test whatever it was meant to test?

(2) Is this test still required, or should it instead me remoned in its entirety? 		When ~/.geotools/oracle.properties is configured to allow other gt-jdbc-oracle online tests to pass, OracleNGDataStoreFactoryTest still fails because is uses its own fixture configuration properties file factory.properties. This file is read from src/test/resources. Attached patch removes redundant fixture configuration files and makes the test use the same file as the others.

(1) Does this test still test whatever it was meant to test?

(2) Is this test still required, or should it instead be removed in its entirety?
Hide
Permalink
Andrea Aime added a comment -
"Is this test still required"? Testing factories is one obvious thing to do, you don't know if a factory is properly registered in SPI if you don't add a test for it that uses the SPI registration. So yeah, every store has to have one test like this one
Show
Andrea Aime added a comment - "Is this test still required"? Testing factories is one obvious thing to do, you don't know if a factory is properly registered in SPI if you don't add a test for it that uses the SPI registration. So yeah, every store has to have one test like this one
Hide
Permalink
Andrea Aime added a comment -
Patch applied with one minor change, the property files have "password", not "passwd"
Show
Andrea Aime added a comment - Patch applied with one minor change, the property files have "password", not "passwd"
Hide
Permalink
Andrea Aime added a comment -
Patch applied on 2.7.x and trunk
Show
Andrea Aime added a comment - Patch applied on 2.7.x and trunk
Andrea Aime made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Ben Caradoc-Davies added a comment -
Andrea, there is a possible problem with a mix of "passwd" and "password" being used; we put both in our properties files. Please see GEOT-3146 and confirm that you are still happy with the change you committed. I will test that it works and report back.
Show
Ben Caradoc-Davies added a comment - Andrea, there is a possible problem with a mix of "passwd" and "password" being used; we put both in our properties files. Please see GEOT-3146 and confirm that you are still happy with the change you committed. I will test that it works and report back.
Ben Caradoc-Davies made changes -
Link This issue relates to GEOT-3146 [ GEOT-3146 ]
Hide
Permalink
Ben Caradoc-Davies added a comment -
JDBCDataStoreFactory specifies "passwd" for the key.
Show
Ben Caradoc-Davies added a comment - JDBCDataStoreFactory specifies "passwd" for the key.
Hide
Permalink
Ben Caradoc-Davies added a comment -
With the patch as committed, I can confirm that OracleNGDataStoreFactoryTest passes, because we put both "passwd" and "password" in our properties files.
Show
Ben Caradoc-Davies added a comment - With the patch as committed, I can confirm that OracleNGDataStoreFactoryTest passes, because we put both "passwd" and "password" in our properties files.
Hide
Permalink
Andrea Aime added a comment -
Yep, I don't like that we have to put passwd and password in the property files, but have no time to spend on that particular fix.
Show
Andrea Aime added a comment - Yep, I don't like that we have to put passwd and password in the property files, but have no time to spend on that particular fix.
Ben Caradoc-Davies made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Andrea Aime
    Reporter:
    Ben Caradoc-Davies
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: