GeoTools

ContentFeatureStore should provide event support to implementors

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 8.0-M3
  • Fix Version/s: None
  • Component/s: data
  • Labels:
    None

Description

ContentFeatureStore does not deal with events directly. The code should be modified to have a canFireEvents() method and wrap the writers with a event throwing one that provides correct event support out of the box.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
It was my intension that the state be passed into the feature writers so they could call the fire methods directly; I understand that the wrapper approach is more in keeping with the design (and less effort for implementors).

So yeah this would not be a bad change; and would make the initial PropertyDataStore example easier.
Show
Jody Garnett added a comment - It was my intension that the state be passed into the feature writers so they could call the fire methods directly; I understand that the wrapper approach is more in keeping with the design (and less effort for implementors). So yeah this would not be a bad change; and would make the initial PropertyDataStore example easier.
Hide
Permalink
Jody Garnett added a comment -
Attached patch; don't have a good implementation to try it out with - any volunteers?
Show
Jody Garnett added a comment - Attached patch; don't have a good implementation to try it out with - any volunteers?
Hide
Permalink
Andrea Aime added a comment -
No time right now, but maybe you could add tests to shapefile-ng?
Show
Andrea Aime added a comment - No time right now, but maybe you could add tests to shapefile-ng?
Hide
Permalink
Jody Garnett added a comment -
That won't work as you are using the DiffFeatureWriter (which kindly issues most of the events for you).

May be able to test when using AUTO_COMMIT ... would need to look at your code?
Show
Jody Garnett added a comment - That won't work as you are using the DiffFeatureWriter (which kindly issues most of the events for you). May be able to test when using AUTO_COMMIT ... would need to look at your code?
Hide
Permalink
Andrea Aime added a comment -
DiffFeatureWriter... I thought I was using it only inside transactions...
Show
Andrea Aime added a comment - DiffFeatureWriter... I thought I was using it only inside transactions...
Hide
Permalink
Jody Garnett added a comment -
Good point; I have made some progress (see -r38423) and have thought of a good way to test. I am reminded that PropertyDataStoreNG is for tutorials; so I will implement a bare bones writer with no events; and then use it to confirm the same test cases pass (i.e. using the wrapper around a simple implementation needs to pass the same tests as using the implementation that handles its own events).

Let me get it working there first before adopting it for shapefile-ng
Show
Jody Garnett added a comment - Good point; I have made some progress (see -r38423) and have thought of a good way to test. I am reminded that PropertyDataStoreNG is for tutorials; so I will implement a bare bones writer with no events; and then use it to confirm the same test cases pass (i.e. using the wrapper around a simple implementation needs to pass the same tests as using the implementation that handles its own events). Let me get it working there first before adopting it for shapefile-ng
Hide
Permalink
Andrea Aime added a comment -
I guess the work on this one stopped? You attached the patch but also said "Let me get it working there first before adopting it for shapefile-ng"
Show
Andrea Aime added a comment - I guess the work on this one stopped? You attached the patch but also said "Let me get it working there first before adopting it for shapefile-ng"
Hide
Permalink
Andrea Aime added a comment -
Is this patch still is any shape to be committed?
Show
Andrea Aime added a comment - Is this patch still is any shape to be committed?

People

  • Assignee:
    Andrea Aime
    Reporter:
    Andrea Aime
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: