No worries at all. Sorry if my email came off as fairly annoyed - I was just expecting less work. But there is some great work there.
I just committed some of the fixes, but most will need to hold off. I need to grapple with a few design issues first. I did fix all the double quotings. And I put in the spatial index creation - I think that's a great improvement. I started to put in the AddGeometryColumn stuff, but then I remembered why we did things as we did in the first place. It is there to maintain the order of geometry attributes. Order does matter in GeoTools, and the code _should_ work so that if you have a geometry attribute in a position other than last it shows up there - so that the FeatureType you added stays the same. This should maybe change, since it is a bit of a ridiculous requirement, and shapefiles for example could never meet it. I think the thing to do will be to dissociate featureTypes from the physical data representation - using mappings and whatnot. We definitely want to go in that direction, see the GeoServer 1.3 roadmap. Would love your feedback when I throw up my thoughts, as it looks like you're going in that direction too. It will leave a bit of a challenge how to do createSchema - but it will at least be possible - if there is room for a looser mapping. Check my comments in the source code - http://svn.geotools.org/geotools/trunk/gt/plugin/postgis/src/org/geotools/data/postgis/PostgisDataStore.java
And welcome to open source programming. Don't hesitate to ask questions, it's needed to get us all working together. Try out svn diff on a file, like after you have modified it a bit - it will report all the changes that you have made to it. It's super useful. If you don't like the changes you can type 'svn revert', and it will take all your changes back. There is lots of functionality - check out the svn book at: http://svnbook.red-bean.com/index.en.html
Also GeoServer will be on 2.1 relatively soon. The trunk of GeoServer is against 2.1. So if your working on GeoServer svn you _should_ be using GeoTools trunk (2.1). But no worries if you're not there yet, it's still a bit unstable - we should get it more so in the next few weeks.