GeoTools

PostgisDataStore.createSchema() not working

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2.M0
  • Fix Version/s: 2.2.0, 2.3.M0
  • Component/s: jdbc-postgis plugin
  • Labels:
    None

Description

The createSchema() function of the PostgisDataStore doesn't work. First it checks to see if the table to be created is not already present, but then it asks the FIDMapper for the table's PKs.
The org.geotools.data.jdbc.fidmapper.getPkColumnInfo() throws a SchemaNotFoundException that cause the createSchema() to fail.
A solution would be to return a new ColumnInfo[0] instead, so that the
buildNoPKMapper() function would be called.
The problem is that FeatureType and AttributeType have no notion of PKs, so how can the buildNoPKMapper() function knows which fields are Pks???
I have a fixed version of PostgisDataStore (albeit it's not general enough to be used as is). Where and how can I submit it???

Bye
Paolo Rizzi

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. GEOT-379 PostgisFIDMapperFactory should be configurable

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Holmes added a comment -
What version of geotools are you on? I changed the fix version to 2.1M3. To submit the fixed version just attach it directly to this issue (there should be an 'attach file' button). I'm the postgis module maintainer, so I can roll it in for you.
Show
Chris Holmes added a comment - What version of geotools are you on? I changed the fix version to 2.1M3. To submit the fixed version just attach it directly to this issue (there should be an 'attach file' button). I'm the postgis module maintainer, so I can roll it in for you.
Hide
Permalink
Chris Holmes added a comment -
linked to 379, as it contains the fixes.
Show
Chris Holmes added a comment - linked to 379, as it contains the fixes.
Hide
Permalink
Cory Horner added a comment -
rewrote much of the createSchema method

please see revisions:
20510 (2.2.x)
20512
20520

20522 (trunk)
Show
Cory Horner added a comment - rewrote much of the createSchema method please see revisions: 20510 (2.2.x) 20512 20520 20522 (trunk)
Hide
Permalink
Andrea Aime added a comment -
Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
Show
Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

People

  • Assignee:
    Cory Horner
    Reporter:
    Paolo Rizzi
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: