GeoTools
  1. GeoTools
  2. GEOT-3657

Update query api to support joins

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.0-M3
    • Component/s: api, data
    • Labels:
      None

      Description

      Adding ability to do joins in a data store query.

        Issue Links

          Activity

          Hide
          Christian Mueller added a comment -
          Zip files containing modified db2 classes. I will commit this changes after the patch is applied.

          All tests passed (total 269 tests)
          Show
          Christian Mueller added a comment - Zip files containing modified db2 classes. I will commit this changes after the patch is applied. All tests passed (total 269 tests)
          Hide
          Justin Deoliveira added a comment -
          Thanks for the review and for getting the tests passing on db2. I just posted a new patch that addresses the following:

          * spatial and temporal joins implemented for oracle, tests passing
          * added flag to run all join tests with/without primary keys exposed
          * added a test for QUery.NO_PROPERTIES (thanks for that Andrea, there was indeed a bug there)
          * cleaned up imports and added missing copyright headers

          I agree that moving forward joins with remove/updates would be great. And the api to control the structure of the feature. However for now I don't have the mandate to start implementing those. But I don't see any blockers there.

          So, if the new patch sounds good and it is acceptable to leave the "nice to haves" as future improvements I would like to commit the patch tomorrow.

          Thanks again for the review guys, i know this was no small patch, the work is much appreciated.
          Show
          Justin Deoliveira added a comment - Thanks for the review and for getting the tests passing on db2. I just posted a new patch that addresses the following: * spatial and temporal joins implemented for oracle, tests passing * added flag to run all join tests with/without primary keys exposed * added a test for QUery.NO_PROPERTIES (thanks for that Andrea, there was indeed a bug there) * cleaned up imports and added missing copyright headers I agree that moving forward joins with remove/updates would be great. And the api to control the structure of the feature. However for now I don't have the mandate to start implementing those. But I don't see any blockers there. So, if the new patch sounds good and it is acceptable to leave the "nice to haves" as future improvements I would like to commit the patch tomorrow. Thanks again for the review guys, i know this was no small patch, the work is much appreciated.
          Hide
          Justin Deoliveira added a comment -
          New (and hopefully final) patch with temporal and join tests/support for mysql and sql server
          Show
          Justin Deoliveira added a comment - New (and hopefully final) patch with temporal and join tests/support for mysql and sql server
          Hide
          Justin Deoliveira added a comment -
          Ok, patch committed to trunk. Christian if you can apply the db2 stuff and then resolve the issue taht would be great. Thanks.
          Show
          Justin Deoliveira added a comment - Ok, patch committed to trunk. Christian if you can apply the db2 stuff and then resolve the issue taht would be great. Thanks.
          Hide
          Christian Mueller added a comment -
          Committed the db2 stuff, all tests passed.
          Show
          Christian Mueller added a comment - Committed the db2 stuff, all tests passed.

            People

            • Assignee:
              Justin Deoliveira
              Reporter:
              Justin Deoliveira
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: