GeoTools
  1. GeoTools
  2. GEOT-3654

Switching to Java 6 for Version 8.0

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 8.0-M1
    • Fix Version/s: 8.0-M1
    • Component/s: None
    • Labels:
      None

      Description

      Collection some patches for a JAVA 6 build. The encoding patch is needed for a build with Oracle JDK.

      Proposal:

      1. developer.patch
        4 kB
        Christian Mueller
      2. encoding.patch
        20 kB
        Christian Mueller
      3. pom.patch
        0.8 kB
        Christian Mueller

        Activity

        Hide
        Andrea Aime added a comment -
        I've just committed the encoding patch. This should make it possible to switch the build server to java 6, though I have memories of seeing a failure in the image comparisons tests last week if one does that (to see the failures one has to install perceptive diff, see the developer guide)
        Show
        Andrea Aime added a comment - I've just committed the encoding patch. This should make it possible to switch the build server to java 6, though I have memories of seeing a failure in the image comparisons tests last week if one does that (to see the failures one has to install perceptive diff, see the developer guide)
        Hide
        Andrea Aime added a comment - - edited
        Yep, the renderer module has 5 tests in which behavior changes between 5 and 6. Both images generated are "good", but java 6 just renders slightly differently lines and positions text around differently. I checked for usage of hash maps and found one, but even using a linked one the test would fail anyways, I believe due to different font metrics handling between the two jdks.
        Long story short, the exemplars used for image comparison tests will likely have to be updated after the switch to java 6.
        Show
        Andrea Aime added a comment - - edited Yep, the renderer module has 5 tests in which behavior changes between 5 and 6. Both images generated are "good", but java 6 just renders slightly differently lines and positions text around differently. I checked for usage of hash maps and found one, but even using a linked one the test would fail anyways, I believe due to different font metrics handling between the two jdks. Long story short, the exemplars used for image comparison tests will likely have to be updated after the switch to java 6.
        Hide
        Justin Deoliveira added a comment -
        Which would be a precursor to switching over the build server i guess since it does have perceptualdiff installed.
        Show
        Justin Deoliveira added a comment - Which would be a precursor to switching over the build server i guess since it does have perceptualdiff installed.
        Hide
        Justin Deoliveira added a comment -
        Ok, build server switched over to java 1.6. So I guess all that is left is to update the developer guide and call this one resolved?
        Show
        Justin Deoliveira added a comment - Ok, build server switched over to java 1.6. So I guess all that is left is to update the developer guide and call this one resolved?
        Hide
        Christian Mueller added a comment -
        Developer patch applied, work completed, thanks to all
        Show
        Christian Mueller added a comment - Developer patch applied, work completed, thanks to all

          People

          • Assignee:
            Unassigned
            Reporter:
            Christian Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: