Switching to Java 6 for Version 8.0

Christian Mueller added a comment - 16/Jun/11 5:43 AM Adding a patch for the developer guide. Can somebody make a review ?

Jody Garnett added a comment - 16/Jun/11 7:53 AM Review of developers guide patch - looks good. "GeoTools is written in the Java Programming Language. The library is targeted for Java 6 (to reflect strong Java Enterprise Edition use)." I would remove the reference to strong Java Enterprise Edition Use - it was only added to cut down the haters who did not understand why we were still at Java 5 - it is not longer needed.

Christian Mueller added a comment - 16/Jun/11 8:17 AM Removed "(to reflect strong Java Enterprise Edition use)."

Jody Garnett added a comment - 16/Jun/11 5:57 PM Ops - was not clear. Please go ahead and commit - the developers guide is a PMC thing - it happens to live in the doc module (but I am only module maintainer of the user guide part).

Christian Mueller added a comment - 16/Jun/11 11:07 PM Is it not better to apply all patches at the same point in time ?

Andrea Aime added a comment - 17/Jun/11 1:04 AM Blindly applying is not an option, the build server has to be switched to java 6 first. A reasonable set of actions: - apply the encoding patches, they should work with java 5 too and allow the build server to switch to java 6 - have the build server maintainer switch to java 6 and apply the pom changes - fix whatever else might break after the switch

Andrea Aime added a comment - 19/Jun/11 2:15 AM I've just committed the encoding patch. This should make it possible to switch the build server to java 6, though I have memories of seeing a failure in the image comparisons tests last week if one does that (to see the failures one has to install perceptive diff, see the developer guide)

Andrea Aime added a comment - 19/Jun/11 2:51 AM - edited Yep, the renderer module has 5 tests in which behavior changes between 5 and 6. Both images generated are "good", but java 6 just renders slightly differently lines and positions text around differently. I checked for usage of hash maps and found one, but even using a linked one the test would fail anyways, I believe due to different font metrics handling between the two jdks. Long story short, the exemplars used for image comparison tests will likely have to be updated after the switch to java 6.

Justin Deoliveira added a comment - 20/Jun/11 8:17 AM Which would be a precursor to switching over the build server i guess since it does have perceptualdiff installed.

Justin Deoliveira added a comment - 27/Jun/11 12:17 PM Ok, build server switched over to java 1.6. So I guess all that is left is to update the developer guide and call this one resolved?

Christian Mueller added a comment - 27/Jun/11 9:04 PM Developer patch applied, work completed, thanks to all