Allow build to use Maven 2 or Maven 3.0

Jody Garnett added a comment - 13/Jun/11 6:55 AM Could you attach your work on maven 3 to this issue; I may be able to scare up someone to look at this over the course of the week.

Andrea Aime added a comment - 13/Jun/11 8:55 AM The only patch I have is this one, apparently it was enough to let it build: {code}  git diff HEAD^..HEAD diff --git a/pom.xml b/pom.xml index 4a5bd96..da438e3 100644 --- a/pom.xml +++ b/pom.xml @@ -71,6 +71,7 @@      <interactive.image>false</interactive.image>      <online.skip.pattern>**/*OnlineTest.java</online.skip.pattern>      <stress.skip.pattern>**/*StressTest.java</stress.skip.pattern> + <test.exclude.pattern>disabled</test.exclude.pattern>      <test.maxHeapSize>512M</test.maxHeapSize>      <src.output>${basedir}/target</src.output>      <imageio.ext.version>1.1-RC1</imageio.ext.version> {code} The error message given about that missing property was really cryptic. I don't remember if I tried a build from a clean local repo, nor I had time to double check the patch now.

Cliff Broadbent added a comment - 16/Jun/11 12:40 AM Am looking into this one at the moment. From a quick look, I'm thinking surefire doesn't like something, or it doesn't gracefully handle exceptions that are zero length strings. If I work it out I'll post a patch.

Cliff Broadbent added a comment - 16/Jun/11 1:44 AM First attempt at a patch to convince Maven3 to play nicely with Geotools

Cliff Broadbent added a comment - 16/Jun/11 1:46 AM And it helps when you attach the correct patch file...

Andrea Aime added a comment - 16/Jun/11 1:55 AM Cliff, how is your patch different from the one I added in the first comment of this jira?

Cliff Broadbent added a comment - 17/Jun/11 1:19 AM The two patches achieve the same thing. Mine simply includes comments and comes in file form as I was unable to apply the code pasted in the initial comment. It would appear the maven-surefire-plugin doesn't handle definition of a null value exclusion gracefully under maven 3. I am raising a change proposal under the GeoTools wiki to move to Maven 3 as the transition appears reasonably straight forward.

Jody Garnett added a comment - 18/Jun/11 12:02 AM The fun part of the proposal will be updating the developers guide; especially the release procedure (if anything has changed in the deploy targets).

Ben Caradoc-Davies added a comment - 28/Jun/11 8:59 PM Cliff, your patch does not apply with "git apply". With patch it require fuzz 2. It also introduces a spurious unicode FEFF sequence before the XML declaration (look in a hex editor, use "od" or vi). And why use this filename? I think Andrea's is self-documenting. And building with -Dall fails in gt-mark-wkt. Investigating.

Ben Caradoc-Davies added a comment - 28/Jun/11 9:23 PM Got it: gt-mark-wkt has a parent mismatch: it is a submodule of unsupported, but declares its parent as library.

Ben Caradoc-Davies added a comment - 28/Jun/11 9:59 PM Attached patch supersedes the earlier patch. It uses Andrea's version of the top-level pom fix and also patches gt-mark-wkt to support building with -Dall.

Ben Caradoc-Davies added a comment - 28/Jun/11 11:08 PM Cliff, as an aside, the U+FEFF at the start of your original patch is a UTF-16 byte order mark: http://en.wikipedia.org/wiki/Byte_order_mark Byte order marks are not recommended for UTF-8 documents. Furthermore, this is the wrong mark for this document, which is declared at UTF-8. Looks like Notepad brain-damage to me.

Andrea Aime added a comment - 29/Jun/11 1:45 AM That U+FEFF is added by a number of broken Windows programs, including Notepad, to mark the byte order. That breaks many xml readers as a result. See also: http://en.wikipedia.org/wiki/Byte_order_mark Back when I was using windows I banned notepad and replaced it with Notepad2, which does not introduce these silly mistakes, does not force windows line endings and so on.

Jody Garnett added a comment - 01/Jul/11 10:18 PM Trying out the patch locally seems good so far.

Jody Garnett added a comment - 02/Jul/11 5:46 AM Commit applied to trunk as of r37549 (not sure if we want this applied to 2.7.x?)

Cliff Broadbent added a comment - 12/Jul/11 10:29 PM Bizarre. I created the patch file using "git diff > patch.file" using git 1.7.6 from http://code.google.com/p/msysgit/downloads/list?can=3 Must have missed a switch somewhere.