GeoTools
  1. GeoTools
  2. GEOT-3615

Allow build to use Maven 2 or Maven 3.0

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 8.0-M1
    • Fix Version/s: None
    • Component/s: admin
    • Labels:
      None

      Description

      Trying out maven 3.0.3 (for reported speed benifits). The build fails on our JAR files collector...

      This is the subject of a proposal here:

      1. GEOT-3615.-Dall.patch
        1 kB
        Ben Caradoc-Davies
      2. patch_GEOT-3615.diff.patch
        0.8 kB
        Cliff Broadbent

        Issue Links

          Activity

          Hide
          Ben Caradoc-Davies added a comment -
          Cliff, as an aside, the U+FEFF at the start of your original patch is a UTF-16 byte order mark:
          http://en.wikipedia.org/wiki/Byte_order_mark

          Byte order marks are not recommended for UTF-8 documents. Furthermore, this is the wrong mark for this document, which is declared at UTF-8.

          Looks like Notepad brain-damage to me.
          Show
          Ben Caradoc-Davies added a comment - Cliff, as an aside, the U+FEFF at the start of your original patch is a UTF-16 byte order mark: http://en.wikipedia.org/wiki/Byte_order_mark Byte order marks are not recommended for UTF-8 documents. Furthermore, this is the wrong mark for this document, which is declared at UTF-8. Looks like Notepad brain-damage to me.
          Hide
          Andrea Aime added a comment -
          That U+FEFF is added by a number of broken Windows programs, including Notepad, to mark the byte order. That breaks many xml readers as a result. See also: http://en.wikipedia.org/wiki/Byte_order_mark
          Back when I was using windows I banned notepad and replaced it with Notepad2, which does not introduce these silly mistakes, does not force windows line endings and so on.
          Show
          Andrea Aime added a comment - That U+FEFF is added by a number of broken Windows programs, including Notepad, to mark the byte order. That breaks many xml readers as a result. See also: http://en.wikipedia.org/wiki/Byte_order_mark Back when I was using windows I banned notepad and replaced it with Notepad2, which does not introduce these silly mistakes, does not force windows line endings and so on.
          Hide
          Jody Garnett added a comment -
          Trying out the patch locally seems good so far.
          Show
          Jody Garnett added a comment - Trying out the patch locally seems good so far.
          Hide
          Jody Garnett added a comment -
          Commit applied to trunk as of r37549

          (not sure if we want this applied to 2.7.x?)
          Show
          Jody Garnett added a comment - Commit applied to trunk as of r37549 (not sure if we want this applied to 2.7.x?)
          Hide
          Cliff Broadbent added a comment -
          Bizarre. I created the patch file using "git diff > patch.file" using git 1.7.6 from http://code.google.com/p/msysgit/downloads/list?can=3

          Must have missed a switch somewhere.
          Show
          Cliff Broadbent added a comment - Bizarre. I created the patch file using "git diff > patch.file" using git 1.7.6 from http://code.google.com/p/msysgit/downloads/list?can=3 Must have missed a switch somewhere.

            People

            • Assignee:
              Jody Garnett
              Reporter:
              Jody Garnett
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: