GeoTools

Support encoding of GML srsName in urn:ogc format

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 8.0-RC1
  • Fix Version/s: 8.0-RC2
  • Component/s: xsd-gml
  • Labels:
    None

Description

Users would like to encode srsName in WFS responses as urn:ogc:def:crs:EPSG::4283 instead of urn:x-ogc:def:crs:EPSG:4283. I also have requests for http://www.opengis.net/def/crs/EPSG/0/4283, the latest format out of the OGC-NA.

This last came up in November:
http://osgeo-org.1803224.n2.nabble.com/srsName-urn-x-ogc-vs-urn-ogc-more-headaches-and-long-term-decisions-td6133528.html

  1. Text File
    GEOT-3581.patch
    28/May/12 11:15 PM
    23 kB
    Justin Deoliveira

Issue Links

is depended upon by

New Feature - A new feature of the product, which has yet to be developed. GEOS-4545 Add option to encode srsName as urn:ogc in WFS responses

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. GEOT-4153 Add support for new style urn for srsName

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. GEOT-4160 Support parsing srsName in OGC HTTP URI format

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ben Caradoc-Davies added a comment -
Looks all hardcoded in gt-xsd-gml2 org.geotools.gml2.bindings.GML2EncodingUtils.toURI.
Show
Ben Caradoc-Davies added a comment - Looks all hardcoded in gt-xsd-gml2 org.geotools.gml2.bindings.GML2EncodingUtils.toURI.
Hide
Permalink
Ben Caradoc-Davies added a comment -
{code}
    public static String toURI(CoordinateReferenceSystem crs, boolean forceOldStyle) {
        String code = epsgCode(crs);
        AxisOrder axisOrder = CRS.getAxisOrder(crs, true);

        if (code != null) {
            if (forceOldStyle ||( (axisOrder == AxisOrder.EAST_NORTH) ||
                    (axisOrder == AxisOrder.INAPPLICABLE)) ) {
                return "http://www.opengis.net/gml/srs/epsg.xml#" + code;
            } else {
                //return "urn:x-ogc:def:crs:EPSG:6.11.2:" + code;
                return "urn:x-ogc:def:crs:EPSG:" + code;
            }
        }

        return null;
    }
{code}
Show
Ben Caradoc-Davies added a comment - {code}     public static String toURI(CoordinateReferenceSystem crs, boolean forceOldStyle) {         String code = epsgCode(crs);         AxisOrder axisOrder = CRS.getAxisOrder(crs, true);         if (code != null) {             if (forceOldStyle ||( (axisOrder == AxisOrder.EAST_NORTH) ||                     (axisOrder == AxisOrder.INAPPLICABLE)) ) {                 return " http://www.opengis.net/gml/srs/epsg.xml# " + code;             } else {                 //return "urn:x-ogc:def:crs:EPSG:6.11.2:" + code;                 return "urn:x-ogc:def:crs:EPSG:" + code;             }         }         return null;     } {code}
Hide
Permalink
Ben Caradoc-Davies added a comment -
Justin created a duplicate GEOT-4153 with the description: 'New style urns look like "urn:ogc:def:crs:EPSG::1234", while the old look like "urn:x-ogc:def:crs:EPSG:1234"'.
Show
Ben Caradoc-Davies added a comment - Justin created a duplicate GEOT-4153 with the description: 'New style urns look like "urn:ogc:def:crs:EPSG::1234", while the old look like "urn:x-ogc:def:crs:EPSG:1234"'.
Hide
Permalink
Justin Deoliveira added a comment -
Hey Ben,

Here is a patch for this one. Geoserver part to come separately. If you could give this a sanity check that would be great.

Also, if you can come up with better names for the items of the SrsSyntax enumeration please do.
Show
Justin Deoliveira added a comment - Hey Ben, Here is a patch for this one. Geoserver part to come separately. If you could give this a sanity check that would be great. Also, if you can come up with better names for the items of the SrsSyntax enumeration please do.
Hide
Permalink
Justin Deoliveira added a comment -
Updated patch that includes gml 3.2 support
Show
Justin Deoliveira added a comment - Updated patch that includes gml 3.2 support
Hide
Permalink
Ben Caradoc-Davies added a comment - - edited
Justin,

the changes look sane.

I suggest renaming this enum SrsFormat and renaming the fields to be a bit more descriptive:

DEFAULT -> EPSG_CODE
LEGACY -> OGC_URL
URN -> OGC_URN_EXPERIMENTAL
URN2 ->OGC_URN
URL -> OGC_HTTP_URI

But then I'm not known for my brevity. :-P

In any case, the last one is known as an HTTP URI not a URL. This is our big change to synchronise jargon. See: https://portal.opengeospatial.org/files/?artifact_id=39467

Kind regards,
Ben.
Show
Ben Caradoc-Davies added a comment - - edited Justin, the changes look sane. I suggest renaming this enum SrsFormat and renaming the fields to be a bit more descriptive: DEFAULT -> EPSG_CODE LEGACY -> OGC_URL URN -> OGC_URN_EXPERIMENTAL URN2 ->OGC_URN URL -> OGC_HTTP_URI But then I'm not known for my brevity. :-P In any case, the last one is known as an HTTP URI not a URL. This is our big change to synchronise jargon. See: https://portal.opengeospatial.org/files/?artifact_id=39467 Kind regards, Ben.
Hide
Permalink
Justin Deoliveira added a comment -
Cool, thanks Ben. The names look good to me.
Show
Justin Deoliveira added a comment - Cool, thanks Ben. The names look good to me.
Hide
Permalink
Ben Caradoc-Davies added a comment -
Justin, I get a failure in gt-xsd-gml3 PointTypeBindingTest, but only the one for GML 3.2 (the test for GML 3.1 passes, but why?).

{noformat}
Failed tests: testEncode(org.geotools.gml3.v3_2.bindings.PointTypeBindingTest): null expected:<urn:[x-ogc:def:crs:EPSG]:4326> but was:<urn:[ogc:def:crs:EPSG:]:4326>
{noformat}
Show
Ben Caradoc-Davies added a comment - Justin, I get a failure in gt-xsd-gml3 PointTypeBindingTest, but only the one for GML 3.2 (the test for GML 3.1 passes, but why?). {noformat} Failed tests: testEncode(org.geotools.gml3.v3_2.bindings.PointTypeBindingTest): null expected:<urn:[x-ogc:def:crs:EPSG]:4326> but was:<urn:[ogc:def:crs:EPSG:]:4326> {noformat}
Hide
Permalink
Justin Deoliveira added a comment -
For gml 3.2 / wfs 2.0 i decided to make the new urn syntax the default, forgot to update that test case.
Show
Justin Deoliveira added a comment - For gml 3.2 / wfs 2.0 i decided to make the new urn syntax the default, forgot to update that test case.

People

  • Assignee:
    Justin Deoliveira
    Reporter:
    Ben Caradoc-Davies
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: