GeoTools

Add Min/MaxScaleDenominator to SLDParser

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.0
  • Fix Version/s: 2.1.M2
  • Component/s: wms extension
  • Labels:
    None

Description

SLDParser.parseRule doesn't look for Min/MaxScaleDenominator elements as per SLD 1.0 spec. Code for handling them is there, but not parsing them from the sld file.

Diff to fix it is below.

Index: module/main/src/org/geotools/styling/SLDParser.java
===================================================================
— module/main/src/org/geotools/styling/SLDParser.java (revision 9796)
+++ module/main/src/org/geotools/styling/SLDParser.java (working copy)
@@ -489,7 +489,15 @@
if (childName.equalsIgnoreCase("Abstract"))

{ rule.setAbstract(child.getFirstChild().getNodeValue()); }

  • +
    + if (childName.equalsIgnoreCase("MinScaleDenominator"))

    { + rule.setMinScaleDenominator(Double.parseDouble(child.getFirstChild().getNodeValue())); + }

    +
    + if (childName.equalsIgnoreCase("MaxScaleDenominator"))

    { + rule.setMaxScaleDenominator(Double.parseDouble(child.getFirstChild().getNodeValue())); + }

    +
    if (childName.equalsIgnoreCase("Filter")) {
    NodeList list = child.getChildNodes();
    Node kid = null;

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. GEOS-262 SLD Min/MaxScaleDenominator

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. GEOS-297 Fail to render label

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Holmes added a comment -
Added explicit link.
Show
Chris Holmes added a comment - Added explicit link.
Hide
Permalink
Gabriel Roldan added a comment -
applyed the patch provided by Paul Lamb.
Show
Gabriel Roldan added a comment - applyed the patch provided by Paul Lamb.
Hide
Permalink
Anonymous added a comment -
The patch is not applied to the source tree as you can see here:

http://svn.geotools.org/geotools/trunk/gt/module/main/src/org/geotools/styling/SLDParser.java

Or am I missing something?
Show
Anonymous added a comment - The patch is not applied to the source tree as you can see here: http://svn.geotools.org/geotools/trunk/gt/module/main/src/org/geotools/styling/SLDParser.java Or am I missing something?
Hide
Permalink
Chris Holmes added a comment -
This could be related to 297, since it uses min and max. Also this patch needs to be applied to the 2.0.x branch. I see it fine at the link provided by anonymous... But that's on 2.1 (trunk), if 297 needs the fix then it needs to be on 2.0.x
Show
Chris Holmes added a comment - This could be related to 297, since it uses min and max. Also this patch needs to be applied to the 2.0.x branch. I see it fine at the link provided by anonymous... But that's on 2.1 (trunk), if 297 needs the fix then it needs to be on 2.0.x

People

  • Assignee:
    Gabriel Roldan
    Reporter:
    Paul Lamb
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: