GeoTools
  1. GeoTools
  2. GEOT-3523

Promote vector grid module to supported

    Details

    • Type: Task Task
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 9.0-beta1
    • Component/s: None
    • Labels:
      None
    • Testcase included:
      yes

      Description

      Please see the associated proposal to move gt-grid from unsupported to extension:
      http://docs.codehaus.org/display/GEOTOOLS/Vector+grids

      (Note originally the suggestion was to merge it into gt-data and there is an old patch for that, but let's pretend that didn't happen).

        Activity

        Hide
        Jody Garnett added a comment -
        Not sure of the status of this one; proposal and patch look static; I think aaime was looking at wrapping this up as a DataStore?
        Show
        Jody Garnett added a comment - Not sure of the status of this one; proposal and patch look static; I think aaime was looking at wrapping this up as a DataStore?
        Hide
        Jody Garnett added a comment -
        Think we need to start voting on the email list; difference between saying "here is a proposal" and asking for feedback; vs says "I am going to go ahead now?" and asking for +1
        Show
        Jody Garnett added a comment - Think we need to start voting on the email list; difference between saying "here is a proposal" and asking for feedback; vs says "I am going to go ahead now?" and asking for +1
        Hide
        Michael Bedward added a comment -
        Ah, OK - sorry for missing that. Well it can wait until the next version, no one has been calling out for vector grids on the user list for a long time.
        Show
        Michael Bedward added a comment - Ah, OK - sorry for missing that. Well it can wait until the next version, no one has been calling out for vector grids on the user list for a long time.
        Hide
        Michael Bedward added a comment -
        Jody, as we discussed on the developer list, this is just waiting for a code review by you and/or Andrea.
        Show
        Michael Bedward added a comment - Jody, as we discussed on the developer list, this is just waiting for a code review by you and/or Andrea.
        Hide
        Jody Garnett added a comment -
        I was unable to apply the provided patch:


        patch -p0 --dry-run -i ~/Desktop/gt-data-vector-grids.patch
        can't find file to patch at input line 5
        Perhaps you used the wrong -p or --strip option?
        The text leading up to this was:
        --------------------------
        |Index: modules/library/data/src/test/java/org/geotools/data/grid/GridsHexagonalTest.java
        |===================================================================
        |--- modules/library/data/src/test/java/org/geotools/data/grid/GridsHexagonalTest.java (revision 0)
        |+++ modules/library/data/src/test/java/org/geotools/data/grid/GridsHexagonalTest.java (working copy)
        --------------------------

        Could I ask that you create the patch again? The provided patch seems to reflect a few modifications made after the files have been moved to the data module. I need the part that moves them to the data module.
        Show
        Jody Garnett added a comment - I was unable to apply the provided patch: patch -p0 --dry-run -i ~/Desktop/gt-data-vector-grids.patch can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: modules/library/data/src/test/java/org/geotools/data/grid/GridsHexagonalTest.java |=================================================================== |--- modules/library/data/src/test/java/org/geotools/data/grid/GridsHexagonalTest.java (revision 0) |+++ modules/library/data/src/test/java/org/geotools/data/grid/GridsHexagonalTest.java (working copy) -------------------------- Could I ask that you create the patch again? The provided patch seems to reflect a few modifications made after the files have been moved to the data module. I need the part that moves them to the data module.
        Hide
        Jody Garnett added a comment -
        Passing back to you to create the patch again
        Show
        Jody Garnett added a comment - Passing back to you to create the patch again
        Hide
        Michael Bedward added a comment -
        Yes - that's a very old patch. But hang on a minute... doesn't there need to be a PMC vote first ? Also, some discussion about whether gt-data is the best place ? (I think it was just an initial suggestion way back)
        Show
        Michael Bedward added a comment - Yes - that's a very old patch. But hang on a minute... doesn't there need to be a PMC vote first ? Also, some discussion about whether gt-data is the best place ? (I think it was just an initial suggestion way back)
        Hide
        Michael Bedward added a comment -
        OK - trying for GeoTools 9.x...

        Updated the proposal at [http://docs.codehaus.org/display/GEOTOOLS/Vector+grids] and edited the issue summary. Now aiming for extension/gt-grid
        Show
        Michael Bedward added a comment - OK - trying for GeoTools 9.x... Updated the proposal at [ http://docs.codehaus.org/display/GEOTOOLS/Vector+grids ] and edited the issue summary. Now aiming for extension/gt-grid
        Hide
        Michael Bedward added a comment - - edited
        Promoted grid module to extension. Moved docs page to extension in user guide.
        Committed to master 93f981a0
        Show
        Michael Bedward added a comment - - edited Promoted grid module to extension. Moved docs page to extension in user guide. Committed to master 93f981a0

          People

          • Assignee:
            Michael Bedward
            Reporter:
            Michael Bedward
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: