GeoTools

JDBC test assumes order of feature retrieval

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.7.0
  • Fix Version/s: 2.7.1
  • Component/s: jdbc
  • Labels:
    None

Description

currently the testGetFeatureReader in JDBCDatastoreTest assumes that the features are retrieved from the database in a certain order and if the database does not return the features in the same order as they are inserted the test fails.

My question:

Is there a rule that states that features must be returned from a feature source in a certain order or could this test be less strict with regards to ordering?

If it is agreed that this is a bug and the test should be rewritten I will do so.

  1. Text File
    order_independent_tests.patch
    30/Mar/11 8:05 AM
    18 kB
    Jesse Eichar
  2. Text File
    order_independent_tests.patch
    29/Mar/11 1:56 PM
    10 kB
    Jesse Eichar

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jesse Eichar added a comment -
Patch with a fix. H2 test all pass still and I have ran all postgis tests and only lob tests fail, which failed for me before the patch as well so I believe those are unrelated failures.
Show
Jesse Eichar added a comment - Patch with a fix. H2 test all pass still and I have ran all postgis tests and only lob tests fail, which failed for me before the patch as well so I believe those are unrelated failures.
Hide
Permalink
Andrea Aime added a comment -
I just had a quick look at the patch and it seems fine to me, though someone should definitely try it out for good.
Show
Andrea Aime added a comment - I just had a quick look at the patch and it seems fine to me, though someone should definitely try it out for good.
Hide
Permalink
Jesse Eichar added a comment -
How do you mean to try it out for good? I have tested against postgis and H2 and it has not affected those tests (at least it does not cause failures).

I am open to suggestions.
Show
Jesse Eichar added a comment - How do you mean to try it out for good? I have tested against postgis and H2 and it has not affected those tests (at least it does not cause failures). I am open to suggestions.
Hide
Permalink
Christian Mueller added a comment -
Tested with DB2, anything ok
Show
Christian Mueller added a comment - Tested with DB2, anything ok
Hide
Permalink
Andrea Aime added a comment -
I mean what Christian just did, actually try out against another db.
In GeoTools+JDBC land there have not been many direct commits lately, me Justin and Christian all provide patches and we cross review them, also checking against the dbs that are maintained by only one of us.
Show
Andrea Aime added a comment - I mean what Christian just did, actually try out against another db. In GeoTools+JDBC land there have not been many direct commits lately, me Justin and Christian all provide patches and we cross review them, also checking against the dbs that are maintained by only one of us.
Hide
Permalink
Jesse Eichar added a comment -
Found more order dependent tests and fixed a couple bugs in the previous implementation
Show
Jesse Eichar added a comment - Found more order dependent tests and fixed a couple bugs in the previous implementation
Hide
Permalink
Christian Mueller added a comment -
Again, all tests of for DB2
Show
Christian Mueller added a comment - Again, all tests of for DB2
Hide
Permalink
Jesse Eichar added a comment -
Thanks guys,

I will commit then. All h2 and postgis tests pass with the changes.
Show
Jesse Eichar added a comment - Thanks guys, I will commit then. All h2 and postgis tests pass with the changes.
Hide
Permalink
Jesse Eichar added a comment -
Ok Changes committed. With luck the build will not be broken. It is end of the day here. I will check tonight and tomorrow morning.
Show
Jesse Eichar added a comment - Ok Changes committed. With luck the build will not be broken. It is end of the day here. I will check tonight and tomorrow morning.
Hide
Permalink
Andrea Aime added a comment -
Changes committed, yet still open. Is there more work to do on this one, or can we close it?
Show
Andrea Aime added a comment - Changes committed, yet still open. Is there more work to do on this one, or can we close it?
Hide
Permalink
Andrea Aime added a comment -
Assuming it's done (have seen work on teradata, nothing on order assumptions lately though)
Show
Andrea Aime added a comment - Assuming it's done (have seen work on teradata, nothing on order assumptions lately though)

People

  • Assignee:
    Unassigned
    Reporter:
    Jesse Eichar
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: