GeoTools
  1. GeoTools
  2. GEOT-3454

Geoserver app-schema: types that only have client properties attributes are always skipped

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: app-schema plugin
    • Labels:
      None

      Description

      As part of the work to skip attributes that are not mandatory and empty, attributes that have no sourceExpression and xlink:href in the ClientProperty are skipped.
      As a result, types like swe:TextBlock are always skipped, because it only has ClientProperty attributes.
      The fix should also exclude attributes that has ClientProperty values other than xlink:href.

      <xs:element name="TextBlock">
      <xs:complexType>
      <xs:complexContent>
      <xs:extension base="swe:AbstractEncodingType">
      <xs:attribute name="tokenSeparator" type="swe:textSeparator" use="required"/>
      <xs:attribute name="blockSeparator" type="swe:textSeparator" use="required"/>
      <xs:attribute name="decimalSeparator" type="swe:decimalSeparator" use="required"/>
      </xs:extension>
      </xs:complexContent>
      </xs:complexType>
      </xs:element>

      <xs:element name="TextBlock">
      <xs:complexType>
      <xs:complexContent>
      <xs:extension base="swe:AbstractEncodingType">
      <xs:attribute name="tokenSeparator" type="swe:textSeparator" use="required"/>
      <xs:attribute name="blockSeparator" type="swe:textSeparator" use="required"/>
      <xs:attribute name="decimalSeparator" type="swe:decimalSeparator" use="required"/>
      </xs:extension>
      </xs:complexContent>
      </xs:complexType>
      </xs:element>

      One way to do this is to add a tag like <skipIfEmpty> tag for the AttributeMapping, with the current behaviour by default (skip if no value).

        Activity

        Hide
        Rini Angreani added a comment -
        This is contradicting with the current requirements (to skip when empty), e.g. when gml:name has no value but it has codeSpace as a constant value in the ClientProperty.
        Client said not to worry.
        Show
        Rini Angreani added a comment - This is contradicting with the current requirements (to skip when empty), e.g. when gml:name has no value but it has codeSpace as a constant value in the ClientProperty. Client said not to worry.
        Hide
        Andrea Aime added a comment -
        Mass closing all issues that have been in "resolved" state for more than one month without further comments
        Show
        Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for more than one month without further comments
        Hide
        Victor Tey added a comment -
        GT Trunk: Completed: At revision: 38805
        GS Trunk: Completed: At revision: 17202

        Show
        Victor Tey added a comment - GT Trunk: Completed: At revision: 38805 GS Trunk: Completed: At revision: 17202

          People

          • Assignee:
            Victor Tey
            Reporter:
            Victor Tey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: