GeoTools

gml:id aren't encoded for non-feature types

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.4
  • Fix Version/s: 2.6.5
  • Component/s: xml
  • Labels:
    None

Description

Some non-feature types extend AbstractGMLType, which allows them to have gml:id attribute.
Only features get ids encoded at the moment though.
For example: gsml:CompoundMaterial extends gsml:EarthMaterial which is not a feature type, but extends AbstractGMLType.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rini Angreani added a comment -
It's because the id isn't set in the java object as a property. The encoding actually goes through the properties from the schema. For features, this is explicitly done in GML3EncodingUtils, that is called from AbstractFeatureTypeBinding. That's why only features get their ids encoded.
Show
Rini Angreani added a comment - It's because the id isn't set in the java object as a property. The encoding actually goes through the properties from the schema. For features, this is explicitly done in GML3EncodingUtils, that is called from AbstractFeatureTypeBinding. That's why only features get their ids encoded.
Hide
Permalink
Rini Angreani added a comment -
Shane Bailie's patch, and the test changes in geoserver FeatureChainingWfsTest.
Show
Rini Angreani added a comment - Shane Bailie's patch, and the test changes in geoserver FeatureChainingWfsTest.
Hide
Permalink
Rini Angreani added a comment -
Hi Justin,

Please review Shane Bailie's patch (ComplexSupportXSAnyTypeBinding.patch) for this issue, affecting complex attributes only.
The test is covered in FeatureChainingWfsTest patch, which I will commit along with this.

Thanks
Rini
Show
Rini Angreani added a comment - Hi Justin, Please review Shane Bailie's patch (ComplexSupportXSAnyTypeBinding.patch) for this issue, affecting complex attributes only. The test is covered in FeatureChainingWfsTest patch, which I will commit along with this. Thanks Rini
Hide
Permalink
Justin Deoliveira added a comment -
+1 looks good.
Show
Justin Deoliveira added a comment - +1 looks good.
Hide
Permalink
Rini Angreani added a comment -
Thank you, Justin.

GT-trunk: Committed revision 35573.
GT-2.6.x: Completed: At revision: 35574

Test committed:
GS-trunk: Committed revision 14429.
GS-2.0.x: Completed: At revision: 14430
Show
Rini Angreani added a comment - Thank you, Justin. GT-trunk: Committed revision 35573. GT-2.6.x: Completed: At revision: 35574 Test committed: GS-trunk: Committed revision 14429. GS-2.0.x: Completed: At revision: 14430
Hide
Permalink
Andrea Aime added a comment -
Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
Show
Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.