GeoTools

Query merge with DefaultQuery

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.7-M0
  • Fix Version/s: 2.7-M0
  • Component/s: data
  • Labels:
    None

Description

This is an easy one; we have Query as an interface and DefaultQuery as the only implementation. Like the only implementation ever ...
<p>
We should recast Query using the DefaultQuery implementation. The DefaultQuery subclass can remain for backwards compatibility.

class Query {
  ...
  public String getHandle() {
    return this.handle;
  }
  ...
}
class DefaultQuery extends Query {
  // empty
}

With this change Query can be used directly:

featureSource.getFeature( new Query( "countries.shp", filter ) );

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. GEOT-3476 FeatureLock merged with DefaultFeatureLock

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
I am also a bit horrified on the age of the javadoc comments for Query/DefaultQuery. Cleaning them up as I go; even if this patch is not accepted I would like to see the javadocs updated.
Show
Jody Garnett added a comment - I am also a bit horrified on the age of the javadoc comments for Query/DefaultQuery. Cleaning them up as I go; even if this patch is not accepted I would like to see the javadocs updated.
Hide
Permalink
Michael Bedward added a comment -
Good idea, and thanks for updating the javadocs !
Show
Michael Bedward added a comment - Good idea, and thanks for updating the javadocs !
Hide
Permalink
Michael Bedward added a comment -
Applied to trunk (r35319). Also involved minor change in feature-pregeneralized plugin.
Show
Michael Bedward added a comment - Applied to trunk (r35319). Also involved minor change in feature-pregeneralized plugin.
Hide
Permalink
Jody Garnett added a comment -
Thanks for getting that one done Micheal.
Show
Jody Garnett added a comment - Thanks for getting that one done Micheal.

People

  • Assignee:
    Michael Bedward
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: