GeoTools
  1. GeoTools
  2. GEOT-2982

All META-INF/services files should have a terminating newline

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.6.3, 2.7-M0
    • Component/s: None
    • Labels:
      None

      Description

      As reported on the user list, the maven shade plugin doesn't merge SPI files properly if they don't end in a terminating newline. That seems a bit lame, but rather than waiting for the plugin to be fixed we can just patch the files.

      The attached patches add terminating newlines to those SPI files missing them in trunk and the 2.6.x branch.

      I'd be grateful if Jody, Andrea or someone else with a broad knowledge of the library could review the patches please.

      1. spi-newlines-2.6.patch
        42 kB
        Michael Bedward
      2. spi-newlines-trunk.patch
        43 kB
        Michael Bedward

        Activity

        Hide
        Andrea Aime added a comment -
        Well, I cannot see how the patch can be harmful. Go ahead and commit :-)
        Show
        Andrea Aime added a comment - Well, I cannot see how the patch can be harmful. Go ahead and commit :-)
        Hide
        Andrea Aime added a comment -
        However, better report this at http://jira.codehaus.org/browse/MSHADE
        Show
        Andrea Aime added a comment - However, better report this at http://jira.codehaus.org/browse/MSHADE
        Hide
        Michael Bedward added a comment -
        Thanks Andrea. I'll follow up with the shade folk.

        Committed on trunk r35018 and 2.6.x branch r35019
        Show
        Michael Bedward added a comment - Thanks Andrea. I'll follow up with the shade folk. Committed on trunk r35018 and 2.6.x branch r35019

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael Bedward
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: