GeoTools

Shapefile: Storing counter clock wise polygons does not work - reverseRing() incorrect

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.2
  • Fix Version/s: 2.6.3
  • Component/s: shapefile plugin
  • Labels:
    None
  • Environment:
    java 1.6
    geotools-2.6.2
  • Testcase included:
    yes

Description

Function: org.geotools.data.shapefile.shp.JTSUtilities.reverseRing(LinearRing)
Line 181: Missing setOrdinate() function call

Current (incorrect):
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
public static final LinearRing reverseRing(LinearRing lr) {
GeometryFactory gf = lr.getFactory();
CoordinateSequenceFactory csf = gf.getCoordinateSequenceFactory();

CoordinateSequence csOrig = lr.getCoordinateSequence();
int numPoints = csOrig.size();
int dimensions = csOrig.getDimension();
CoordinateSequence csNew = csf.create(numPoints, dimensions);

for (int i = 0; i < numPoints; i++) {
for (int j = 0; j < dimensions; j++)

{ csOrig.getOrdinate(i, j); }

}

return gf.createLinearRing(csNew);
}
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

Modified (correct):
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
public static final LinearRing reverseRing(LinearRing lr) {
GeometryFactory gf = lr.getFactory();
CoordinateSequenceFactory csf = gf.getCoordinateSequenceFactory();

CoordinateSequence csOrig = lr.getCoordinateSequence();
int numPoints = csOrig.size();
int dimensions = csOrig.getDimension();
CoordinateSequence csNew = csf.create(numPoints, dimensions);

for (int i = 0; i < numPoints; i++) {
for (int j = 0; j < dimensions; j++)

{ csNew.setOrdinate(i,j, csOrig.getOrdinate(i, j)); }

}

return gf.createLinearRing(csNew);
}
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. UDIG-1615 Create Polygon Tool Validation Broken

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment -
Thanks for pointing this out. By any chance, do you also have time to cook a unit test that proves it's working and makes sure we won't see it regress anymore?
Show
Andrea Aime added a comment - Thanks for pointing this out. By any chance, do you also have time to cook a unit test that proves it's working and makes sure we won't see it regress anymore?
Hide
Permalink
Jody Garnett added a comment -
This issue basically stopped the uDig 1.2 RC1 release dead in the water.

I will make a unit test tomorrow.
Show
Jody Garnett added a comment - This issue basically stopped the uDig 1.2 RC1 release dead in the water. I will make a unit test tomorrow.
Hide
Permalink
Jody Garnett added a comment -
So the original code always returned an empty coordinate sequence (sigh).

It looks like the goal here is to produce a reversed copy (indeed a deep copy in which all the ordiante/dimension values are copied rather then just x/y).

The code is only called in a few places:
- assignHolestoShells
- buildGeometries
- makeGoodShapePolygon
- read( ByteBuffer, ShapeType)

Test case and patch attached.
Show
Jody Garnett added a comment - So the original code always returned an empty coordinate sequence (sigh). It looks like the goal here is to produce a reversed copy (indeed a deep copy in which all the ordiante/dimension values are copied rather then just x/y). The code is only called in a few places: - assignHolestoShells - buildGeometries - makeGoodShapePolygon - read( ByteBuffer, ShapeType) Test case and patch attached.
Hide
Permalink
Jody Garnett added a comment -
Confirm fixed works (ie passes tests) and solves issue in uDig.

Andrea has reviewed the patch (spelling mistake and incorrect formatting) and applied as of -r35034
Show
Jody Garnett added a comment - Confirm fixed works (ie passes tests) and solves issue in uDig. Andrea has reviewed the patch (spelling mistake and incorrect formatting) and applied as of -r35034

People

  • Assignee:
    Andrea Aime
    Reporter:
    Marcel Heckel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: