GeoTools

JNDI factories lack the extra parameters the base factory exposes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.1
  • Fix Version/s: 2.6.2
  • Component/s: jdbc
  • Labels:
    None

Description

The JDNI factory wraps the "standard" one but exposes just a limited set of params.

I see a few alternatives:

  • the JNDI one should take the parameter list exposed by the wrapped factory, and either remove the ones that we know are related to the connection pool
  • the JNDI one is provided with a list of well known params that it should expose back from the wrapped factory
  • all subclasses are supposed to override the base class and add back the extra params

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. GEOS-3683 JNDI factories lack the extra parameters the base factory exposes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -
I think 1) seems easiest, just some tweaks to setupParameters(). So which ones exactly would be remove?

* connection params
* host
* port
* username
* password

Any others?
Show
Justin Deoliveira added a comment - I think 1) seems easiest, just some tweaks to setupParameters(). So which ones exactly would be remove? * connection params * host * port * username * password Any others?
Hide
Permalink
Andrea Aime added a comment -
Actually implementing the Oracle OCI yesterday I found a serious problem with the approach in 1) (which I preferred too): by tweaking the parameters one gets a param order that makes no sense, and there does not seem any way to insert values before/after a known value (even if the map is actually a LinkedHashMap).
So in the OCI case I ended up adding all params manually.

I think we could make it work, but we'd have to create some utility to perfom insertions before/after a certain known key, something like
insert(String beforeKey, Object key, Object value) and eventually
insertAll(String beforeKey, Map values)

which internally would copy the contents into another LinkedHashMap, then clean and add back items one by one, shuffling in the new values at the right moment.
Show
Andrea Aime added a comment - Actually implementing the Oracle OCI yesterday I found a serious problem with the approach in 1) (which I preferred too): by tweaking the parameters one gets a param order that makes no sense, and there does not seem any way to insert values before/after a known value (even if the map is actually a LinkedHashMap). So in the OCI case I ended up adding all params manually. I think we could make it work, but we'd have to create some utility to perfom insertions before/after a certain known key, something like insert(String beforeKey, Object key, Object value) and eventually insertAll(String beforeKey, Map values) which internally would copy the contents into another LinkedHashMap, then clean and add back items one by one, shuffling in the new values at the right moment.
Hide
Permalink
Justin Deoliveira added a comment -
Perhaps it would be simpler to just go with approach (3) and just have each subclass responsible for creating the connection param map from scratch. Although if you think its simpler to go with the above approach I am fine with that too. No strong opinion on this one.
Show
Justin Deoliveira added a comment - Perhaps it would be simpler to just go with approach (3) and just have each subclass responsible for creating the connection param map from scratch. Although if you think its simpler to go with the above approach I am fine with that too. No strong opinion on this one.
Hide
Permalink
Andrea Aime added a comment -
Fixed on 1.7.x and trunk
Show
Andrea Aime added a comment - Fixed on 1.7.x and trunk

People

  • Assignee:
    Andrea Aime
    Reporter:
    Andrea Aime
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: