GeoTools
  1. GeoTools
  2. GEOT-2844

Refactor FitlerToSQL to remove duplication in subclasses

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.6.1, 2.7-M0
    • Component/s: jdbc
    • Labels:
      None

      Description

      Currently there seems to be duplication among a number of the FilterToSQL classes:

      PreparedFilterToSQL.visitBinarySpatialOperator()
      PostgisPreparedFilterToSQL.visitBinarySpatialOperator()

      And currently I am looking at implementing the SQLServer and MySQL equivalents, which will duplicate the logic more. I think the logic can be pulled up into FilterToSQL.

        Issue Links

          Activity

          Hide
          Justin Deoliveira added a comment -
          Here is the patch, i ran tests on all databases except for db2.
          Show
          Justin Deoliveira added a comment - Here is the patch, i ran tests on all databases except for db2.
          Hide
          Christian Mueller added a comment -
          Tested for DB2 (trunk,2.6.x) --> ok
          Show
          Christian Mueller added a comment - Tested for DB2 (trunk,2.6.x) --> ok
          Hide
          Andrea Aime added a comment -
          Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
          Show
          Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

            People

            • Assignee:
              Justin Deoliveira
              Reporter:
              Justin Deoliveira
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: