GeoTools

Refactor FitlerToSQL to remove duplication in subclasses

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.0
  • Fix Version/s: 2.6.1, 2.7-M0
  • Component/s: jdbc
  • Labels:
    None

Description

Currently there seems to be duplication among a number of the FilterToSQL classes:

PreparedFilterToSQL.visitBinarySpatialOperator()
PostgisPreparedFilterToSQL.visitBinarySpatialOperator()

And currently I am looking at implementing the SQLServer and MySQL equivalents, which will duplicate the logic more. I think the logic can be pulled up into FilterToSQL.

Issue Links

is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. GEOS-3665 Refactor FitlerToSQL to remove duplication in subclasses

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -
Here is the patch, i ran tests on all databases except for db2.
Show
Justin Deoliveira added a comment - Here is the patch, i ran tests on all databases except for db2.
Hide
Permalink
Christian Mueller added a comment -
Tested for DB2 (trunk,2.6.x) --> ok
Show
Christian Mueller added a comment - Tested for DB2 (trunk,2.6.x) --> ok
Hide
Permalink
Andrea Aime added a comment -
Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
Show
Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

People

  • Assignee:
    Justin Deoliveira
    Reporter:
    Justin Deoliveira
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: