GeoTools

DbaseFileHeader bug in attribute class assignement

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0.RC1
  • Fix Version/s: None
  • Component/s: shapefile plugin
  • Labels:
    None
  • Environment:
    Windows, Java

Description

DbaseFileHeader mistakes when a "number" type arrives: it always assigns "Integer" type.
If the number is too big, it could not fit into an Integer (as in my case), so I made this modification in getFieldClass:

case 'N':
if (fields[i].decimalCount == 0)

{ if (fields[i].fieldLength>9) typeClass = Long.class; else typeClass = Integer.class; }

else

{ typeClass = Double.class; }

break;

  1. Java Source File
    DbaseFileHeader.java
    27/Sep/04 10:04 AM
    21 kB
    Alessandro Monopoli

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alessandro Monopoli added a comment -
Here is the class with the problem solved
Show
Alessandro Monopoli added a comment - Here is the class with the problem solved
Hide
Permalink
Andrea Aime added a comment -
I would find a Long and a BigInteger more appropriate if an Integer does not have enough bits...
Show
Andrea Aime added a comment - I would find a Long and a BigInteger more appropriate if an Integer does not have enough bits...
Hide
Permalink
Andrea Aime added a comment -
Whoops, sorry, I did not read properly your code, sorry. I'm wondering if there may be a case in which not even the Long is big enough... in such a case a BigInteger would be needed.
Show
Andrea Aime added a comment - Whoops, sorry, I did not read properly your code, sorry. I'm wondering if there may be a case in which not even the Long is big enough... in such a case a BigInteger would be needed.
Hide
Permalink
Alessandro Monopoli added a comment -
I don't know :-) I tried "Long" and It worked fine with Teleatlas huge IDs. I don't know if can exists even bigger number then those :D
Show
Alessandro Monopoli added a comment - I don't know :-) I tried "Long" and It worked fine with Teleatlas huge IDs. I don't know if can exists even bigger number then those :D
Hide
Permalink
James Macgill added a comment -
Could you upload a small sample dbf file so that we can add an extra unit test to cover this.
Show
James Macgill added a comment - Could you upload a small sample dbf file so that we can add an extra unit test to cover this.
Hide
Permalink
Alessandro Monopoli added a comment -
Sure I can! :-) Sorry for the delay
Show
Alessandro Monopoli added a comment - Sure I can! :-) Sorry for the delay
Hide
Permalink
Alessandro Monopoli added a comment -
Ehmm... I don't find the link to upload a file :-(
Show
Alessandro Monopoli added a comment - Ehmm... I don't find the link to upload a file :-(
Hide
Permalink
Andrea Aime added a comment -
Can you send it to me then? andrea.aime@aliceposta.it
A small one, please :-)
Show
Andrea Aime added a comment - Can you send it to me then? andrea.aime@aliceposta.it A small one, please :-)
Hide
Permalink
Jody Garnett added a comment -
This is a patch to allow larger numbers out of a shapefile.
Show
Jody Garnett added a comment - This is a patch to allow larger numbers out of a shapefile.
Hide
Permalink
Andrea Aime added a comment -
The current code reads as:

{code}
case 'N':
            if (fields[i].decimalCount == 0) {
                if (fields[i].fieldLength < 10) {
                    typeClass = Integer.class;
                } else {
                    typeClass = Long.class;
                }
            } else {
                typeClass = Double.class;
            }
            break;
{code}

So I guess the user suggestion was merged
Show
Andrea Aime added a comment - The current code reads as: {code} case 'N':             if (fields[i].decimalCount == 0) {                 if (fields[i].fieldLength < 10) {                     typeClass = Integer.class;                 } else {                     typeClass = Long.class;                 }             } else {                 typeClass = Double.class;             }             break; {code} So I guess the user suggestion was merged

People

  • Assignee:
    Jesse Eichar
    Reporter:
    Alessandro Monopoli
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: