GeoTools

Improve StreamingRenderer handling of render events

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5.7, 2.6-M1
  • Fix Version/s: 2.5.8, 2.6-M2
  • Component/s: render
  • Labels:
    None

Description

StreamingRenderer may hold one or more RenderListener that get notified of every feature rendered and any exception occurred while in the rendering loop.
This way, StreamingRenderer defers the decision on when to stop rendering to client code, making for a best effort strategy to handle as much content as possible.

The list of listeners is held in a CopyOnWriteArrayList for maximum performance, yet around a 10% of the time spent by the renderer is consumed by the fireFeatureRendered and fireErrorOcurred methods which can be saved if the list of listeners is not asked for an iterator but index based access is used instead, as per in the following patch:

Index: StreamingRenderer.java
===================================================================
--- StreamingRenderer.java	(revision 33604)
+++ StreamingRenderer.java	(working copy)
@@ -381,15 +381,23 @@
         if( !(feature instanceof SimpleFeature)){
             return;
         }
-		for(RenderListener listener : renderListeners) {
-			listener.featureRenderer((SimpleFeature) feature);
-		}
+        if (renderListeners.size() > 0) {
+            RenderListener listener;
+            for (int i = 0; i < renderListeners.size(); i++) {
+                listener = renderListeners.get(i);
+                listener.featureRenderer((SimpleFeature) feature);
+            }
+        }
 	}
 
 	private void fireErrorEvent(Exception e) {
-	    for(RenderListener listener : renderListeners) {
-			listener.errorOccurred(e);
-		}
+        if (renderListeners.size() > 0) {
+            RenderListener listener;
+            for (int i = 0; i < renderListeners.size(); i++) {
+                listener = renderListeners.get(i);
+                listener.errorOccurred(e);
+            }
+        }
 	}
 
 	/**

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. GEOS-3277 Improve error handling for WMS GetMap requests so only a well known set of rendering exceptions are ignored

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Task - A task that needs to be done. GEOS-3403 port fix for GEOS-3277 to 1.7.x

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gabriel Roldan added a comment -
fixed at r33605
Show
Gabriel Roldan added a comment - fixed at r33605
Gabriel Roldan made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Gabriel Roldan made changes -
Link This issue is depended upon by GEOS-3277 [ GEOS-3277 ]
Hide
Permalink
Gabriel Roldan added a comment -
reopening to apply the same improvement to ShapefileRenderer
Show
Gabriel Roldan added a comment - reopening to apply the same improvement to ShapefileRenderer
Gabriel Roldan made changes -
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Gabriel Roldan added a comment -
StreamingRenderer fixed at r33606
Show
Gabriel Roldan added a comment - StreamingRenderer fixed at r33606
Gabriel Roldan made changes -
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]
Hide
Permalink
Gabriel Roldan added a comment -
reopening in order to backport to 2.5.x
Show
Gabriel Roldan added a comment - reopening in order to backport to 2.5.x
Gabriel Roldan made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Gabriel Roldan made changes -
Affects Version/s 2.5.7 [ 15368 ]
Fix Version/s 2.5.8 [ 15543 ]
Gabriel Roldan made changes -
Link This issue is depended upon by GEOS-3403 [ GEOS-3403 ]
Hide
Permalink
Gabriel Roldan added a comment -
ported to 2.5.x at r33814
Show
Gabriel Roldan added a comment - ported to 2.5.x at r33814
Gabriel Roldan made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Gabriel Roldan
    Reporter:
    Gabriel Roldan
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: