GeoTools

ProcessFactory should extend OptionalFactory

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.0, 2.7-M0
  • Fix Version/s: 2.6.1, 2.7-M0
  • Component/s: unsupported
  • Labels:
    None

Description

ProcessFactory should extend OptionalFactory.

Suppose you have a factory for processing which requires an external DLL (from a processing software) to let the process work.
Checking the isAvailable method allows to know whether all the required stuff is on place to enable the processing or not.

  1. Text File
    process.patch
    20/May/09 2:19 AM
    3 kB
    Daniele Romagnoli
  2. File
    processpatch.diff
    29/Oct/09 7:36 AM
    3 kB
    Daniele Romagnoli

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
Daniele; since this is an unsupported module do you want to queue up the change; ask Graham and then commit? It sounds like you can do this in a consistent manner to the other geotools plugins with which you have experience.
Show
Jody Garnett added a comment - Daniele; since this is an unsupported module do you want to queue up the change; ask Graham and then commit? It sounds like you can do this in a consistent manner to the other geotools plugins with which you have experience.
Hide
Permalink
Daniele Romagnoli added a comment -
This change requires implementing isAvailable method and getImplementationHints in the classes implementing the interface.
The AbstractProcessFactory implementing it may contain a default isAvailable implementation returning true, as well as a default getImplementationHints returning an Empty Map.

The provided patch contains these changes for the process module.
Show
Daniele Romagnoli added a comment - This change requires implementing isAvailable method and getImplementationHints in the classes implementing the interface. The AbstractProcessFactory implementing it may contain a default isAvailable implementation returning true, as well as a default getImplementationHints returning an Empty Map. The provided patch contains these changes for the process module.
Hide
Permalink
Daniele Romagnoli added a comment -
Fixed as revision 33653
Show
Daniele Romagnoli added a comment - Fixed as revision 33653
Hide
Permalink
Daniele Romagnoli added a comment -
Reopening Issue to propose the same fix on 2.6.x and trunk
Show
Daniele Romagnoli added a comment - Reopening Issue to propose the same fix on 2.6.x and trunk
Hide
Permalink
Daniele Romagnoli added a comment -
Hi Michael.
Being you the module mantainer of the process module and being you the more active developer on it, can you take a look on this?

The attached processpatch.diff should add this capability.

Regards,
Daniele
Show
Daniele Romagnoli added a comment - Hi Michael. Being you the module mantainer of the process module and being you the more active developer on it, can you take a look on this? The attached processpatch.diff should add this capability. Regards, Daniele
Hide
Permalink
Michael Bedward added a comment -
Hi Daniele,

Thanks for this. The patch looks fine to me, I'm happy to commit to trunk and 2.6.x

cheers
Michael
Show
Michael Bedward added a comment - Hi Daniele, Thanks for this. The patch looks fine to me, I'm happy to commit to trunk and 2.6.x cheers Michael
Hide
Permalink
Michael Bedward added a comment -
committed to trunk (r34287) and 2.6.x (r34288)
Show
Michael Bedward added a comment - committed to trunk (r34287) and 2.6.x (r34288)

People

  • Assignee:
    Michael Bedward
    Reporter:
    Daniele Romagnoli
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: