GeoTools
  1. GeoTools
  2. GEOT-2474

Improve support for encoding complex features

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.6-M2
    • Fix Version/s: None
    • Component/s: xsd extensions
    • Labels:
      None

      Description

      Attached patch improves support for encoding complex features. This patch includes the changes in the patch attached to GEOT-2455, which is superseded by this patch.

      Changes include:

      • Adding two new GML3 bindings to permit encoding of attributes simpleContent for complexType with simpleContent: the two supported types are CodeType and StringOrRefType.
      • Improved checking for supported descriptors in GML2EncodingUtils.
      • Disabled automatic conversion of ComplexAttribute in ElementEncodeExecutor (should not see the toString() of a complex feature in your XML)
      • Support encoding of generic attributes stored in UserData map of complex attributes.

        Issue Links

          Activity

          Hide
          Ben Caradoc-Davies added a comment -
          All this testing is on GeoTools trunk r32955 and GeoServer trunk r12370.
          Show
          Ben Caradoc-Davies added a comment - All this testing is on GeoTools trunk r32955 and GeoServer trunk r12370.
          Hide
          Justin Deoliveira added a comment -
          Hi Ben, if CITE is good, the patch looks good to me. But can you make a bit fat comment around the check for ComplexAttribute, basically state why we hardcode the check, and eventually hopefully we can find a better way to solve that later.

          As for the GeoServerLoader issue (GEOS-2922), I don't see a patch anywhere.,
          Show
          Justin Deoliveira added a comment - Hi Ben, if CITE is good, the patch looks good to me. But can you make a bit fat comment around the check for ComplexAttribute, basically state why we hardcode the check, and eventually hopefully we can find a better way to solve that later. As for the GeoServerLoader issue ( GEOS-2922 ), I don't see a patch anywhere.,
          Hide
          Ben Caradoc-Davies added a comment - - edited
          Thanks very much, Justin.

          Patch plus big fat ElementEncodeExecutor comment (sans apsirations) committed as r32989.
          Show
          Ben Caradoc-Davies added a comment - - edited Thanks very much, Justin. Patch plus big fat ElementEncodeExecutor comment (sans apsirations) committed as r32989.
          Hide
          Ben Caradoc-Davies added a comment -
          Patch applied.
          Show
          Ben Caradoc-Davies added a comment - Patch applied.
          Hide
          Andrea Aime added a comment -
          Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
          Show
          Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

            People

            • Assignee:
              Ben Caradoc-Davies
              Reporter:
              Ben Caradoc-Davies
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: