GeoTools
  1. GeoTools
  2. GEOT-2434

enable the option to validate fids before they are turned into SQL

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.6-M1
    • Fix Version/s: 2.6-M2
    • Component/s: jdbc
    • Labels:
      None

      Description

      This patch sets a FIDValidator on the simplifying filter visitor which validates the fid before send it to the database. I am not sure if we want to make this the default or not. Perhaps it is smart to make this an option and add a datastore factory parameter for it. That would work for me, as my motivation is to get cite tests in geoserver passing, so an option would allow me to do that.

        Activity

        Hide
        Justin Deoliveira added a comment -
        Andrea and Christian, added you as watchers to this issue, a review would be greatly appreciated.
        Show
        Justin Deoliveira added a comment - Andrea and Christian, added you as watchers to this issue, a review would be greatly appreciated.
        Hide
        Andrea Aime added a comment -
        I'm +1 on having this on by default, FID that do not conform to the expected format won't return any valid result in the luckiest case, and will break the pk column extractor in the worst.
        Show
        Andrea Aime added a comment - I'm +1 on having this on by default, FID that do not conform to the expected format won't return any valid result in the luckiest case, and will break the pk column extractor in the worst.
        Hide
        Christian Mueller added a comment -
        Applied the patch and did a "mvn clean install" on db2-ng. No errors reported. I also applied the patch to 2.5.x and it works too
        Show
        Christian Mueller added a comment - Applied the patch and did a "mvn clean install" on db2-ng. No errors reported. I also applied the patch to 2.5.x and it works too
        Hide
        Justin Deoliveira added a comment -
        Thanks for the review guys. Committed to 2.5.x and trunk.
        Show
        Justin Deoliveira added a comment - Thanks for the review guys. Committed to 2.5.x and trunk.
        Hide
        Andrea Aime added a comment -
        Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
        Show
        Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

          People

          • Assignee:
            Justin Deoliveira
            Reporter:
            Justin Deoliveira
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: