Details

    • Type: New Feature New Feature
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.0-M1
    • Component/s: main
    • Labels:
      None

      Description

      Add temporal filter support based on the filter 2.0 specification. This involves:

      • Adding filter model classes for all the temporal operations
      • Updating FilterFactory and friends
      • Updating FilterVisitor and all implementations

      Change proposal:

      1. GEOT-2367.patch
        189 kB
        Justin Deoliveira

        Issue Links

          Activity

          Hide
          Jody Garnett added a comment -
          And details here Justin? Right now the bug report is not complete as I don't know what the temporal filter classes are.
          Show
          Jody Garnett added a comment - And details here Justin? Right now the bug report is not complete as I don't know what the temporal filter classes are.
          Hide
          Justin Deoliveira added a comment -
          Here is the initial patch for this one.
          Show
          Justin Deoliveira added a comment - Here is the initial patch for this one.
          Hide
          Jody Garnett added a comment -
          Not actually fixed until we have updated to docs / completed the tasks etc..
          Show
          Jody Garnett added a comment - Not actually fixed until we have updated to docs / completed the tasks etc..
          Hide
          Jody Garnett added a comment -
          Docs available for your review; direct use of DefaultInstance and DefaultPeriod were a bit rough. Perhaps we can make a "Temporal" utility class for main to make creating these things a bit easier.
          Show
          Jody Garnett added a comment - Docs available for your review; direct use of DefaultInstance and DefaultPeriod were a bit rough. Perhaps we can make a "Temporal" utility class for main to make creating these things a bit easier.
          Hide
          Justin Deoliveira added a comment -
          Docs look good... and please no not another utility class :) I would rather just make DefaultInstant and DefaultPeriod easier to use by adding constructors that take dates... rather than Position instances.
          Show
          Justin Deoliveira added a comment - Docs look good... and please no not another utility class :) I would rather just make DefaultInstant and DefaultPeriod easier to use by adding constructors that take dates... rather than Position instances.
          Hide
          Jody Garnett added a comment -
          That is fine as well; it is just they are super scary to use right now. So does it just depend who does the work first :-)
          Show
          Jody Garnett added a comment - That is fine as well; it is just they are super scary to use right now. So does it just depend who does the work first :-)
          Hide
          Justin Deoliveira added a comment -
          Super scary? /me rolls eyes. It is a direct api Jody. Please don't go adding things that are not necessary. You really have a bad tendency to do this imo. In my opinion that makes the api way harder to use and understand than going through a direct route, even if it does involve one extra class in between.
          Show
          Justin Deoliveira added a comment - Super scary? /me rolls eyes. It is a direct api Jody. Please don't go adding things that are not necessary. You really have a bad tendency to do this imo. In my opinion that makes the api way harder to use and understand than going through a direct route, even if it does involve one extra class in between.
          Hide
          Jody Garnett added a comment -
          Let me just say it can be made easier - by adding additional constructors.
          Show
          Jody Garnett added a comment - Let me just say it can be made easier - by adding additional constructors.
          Hide
          Jody Garnett added a comment -
          Closing off issues prior to release; going to see if the sub tasks stay open.
          Show
          Jody Garnett added a comment - Closing off issues prior to release; going to see if the sub tasks stay open.

            People

            • Assignee:
              Justin Deoliveira
              Reporter:
              Justin Deoliveira
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: