GeoTools

Support FeatureType in FeatureTypes.isDescendedFrom

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6-M0
  • Fix Version/s: None
  • Component/s: main
  • Labels:
    None

Description

The attached patch widens FeatureTypes.isDescendedFrom to support FeatureType. Argument type is widened and implementation is the same, so backwards compatibility is assured.

The patch also fixes generic type checking in these methods, and reformats.

Also fixes an obvious logic bug (duplicate add) in getAncestors, found while fixing generics.

Issue Links

is depended upon by

Sub-task - The sub-task of the issue GEOS-2569 Change main module to use DataAccess API (GSIP 31)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
Hey dude; next time you submit a patch can we have a test case showing the problem you are fixing; so we can confirm you fixed it?"
Show
Jody Garnett added a comment - Hey dude; next time you submit a patch can we have a test case showing the problem you are fixing; so we can confirm you fixed it?"
Hide
Permalink
Ben Caradoc-Davies added a comment -
Hmm, the change is for code calling it with a FeatureType to compile. Test case: GeoServer after GSIP 31. Point taken, but this is an interface not a functional change.
Show
Ben Caradoc-Davies added a comment - Hmm, the change is for code calling it with a FeatureType to compile. Test case: GeoServer after GSIP 31. Point taken, but this is an interface not a functional change.
Hide
Permalink
Ben Caradoc-Davies added a comment -
Patch has been committed to trunk.

I did claim to fix a bug, so I owe Jody a unit test.
Show
Ben Caradoc-Davies added a comment - Patch has been committed to trunk. I did claim to fix a bug, so I owe Jody a unit test.
Hide
Permalink
Ben Caradoc-Davies added a comment -
I added a test of FeatureTypes.getAncestors() to FeatureTypeTest to confirm that the fix claimed above was correct..
Show
Ben Caradoc-Davies added a comment - I added a test of FeatureTypes.getAncestors() to FeatureTypeTest to confirm that the fix claimed above was correct..
Hide
Permalink
Andrea Aime added a comment -
Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
Show
Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

People

  • Assignee:
    Jody Garnett
    Reporter:
    Ben Caradoc-Davies
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: