GeoTools
  1. GeoTools
  2. GEOT-2270

Support FeatureType in FeatureTypes.isDescendedFrom

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.6-M0
    • Fix Version/s: None
    • Component/s: main
    • Labels:
      None

      Description

      The attached patch widens FeatureTypes.isDescendedFrom to support FeatureType. Argument type is widened and implementation is the same, so backwards compatibility is assured.

      The patch also fixes generic type checking in these methods, and reformats.

      Also fixes an obvious logic bug (duplicate add) in getAncestors, found while fixing generics.

        Issue Links

          Activity

          Hide
          Jody Garnett added a comment -
          Hey dude; next time you submit a patch can we have a test case showing the problem you are fixing; so we can confirm you fixed it?"
          Show
          Jody Garnett added a comment - Hey dude; next time you submit a patch can we have a test case showing the problem you are fixing; so we can confirm you fixed it?"
          Hide
          Ben Caradoc-Davies added a comment -
          Hmm, the change is for code calling it with a FeatureType to compile. Test case: GeoServer after GSIP 31. Point taken, but this is an interface not a functional change.
          Show
          Ben Caradoc-Davies added a comment - Hmm, the change is for code calling it with a FeatureType to compile. Test case: GeoServer after GSIP 31. Point taken, but this is an interface not a functional change.
          Hide
          Ben Caradoc-Davies added a comment -
          Patch has been committed to trunk.

          I did claim to fix a bug, so I owe Jody a unit test.
          Show
          Ben Caradoc-Davies added a comment - Patch has been committed to trunk. I did claim to fix a bug, so I owe Jody a unit test.
          Hide
          Ben Caradoc-Davies added a comment -
          I added a test of FeatureTypes.getAncestors() to FeatureTypeTest to confirm that the fix claimed above was correct..
          Show
          Ben Caradoc-Davies added a comment - I added a test of FeatureTypes.getAncestors() to FeatureTypeTest to confirm that the fix claimed above was correct..
          Hide
          Andrea Aime added a comment -
          Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
          Show
          Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

            People

            • Assignee:
              Jody Garnett
              Reporter:
              Ben Caradoc-Davies
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: