GeoTools
  1. GeoTools
  2. GEOT-2234

Split JDBCGeometryAssociationTestSupport into a test and a setup class

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.5.2
    • Fix Version/s: 2.5.7
    • Component/s: jdbc
    • Labels:
      None

      Description

      Unlike other test classes this class ends in "Support" and it seems it requires a custom setup, but that has been implemented in H2 only.
      Would be nice if this one followed the same conventions as the other tests so that it's clear what another db has to do in order to support
      that feature... I guess it would be interesting to have xlink support in postgis as well no?

        Activity

        Hide
        Justin Deoliveira added a comment -
        Hmmm... I would not be against turning it into a test setup class but i see little value in porting it to other db's. To say it "works" with H2 is giving it way too much credit. It is an ugly hack... one i hope to remove from JDBCFeatureReader into a subclass.
        Show
        Justin Deoliveira added a comment - Hmmm... I would not be against turning it into a test setup class but i see little value in porting it to other db's. To say it "works" with H2 is giving it way too much credit. It is an ugly hack... one i hope to remove from JDBCFeatureReader into a subclass.
        Hide
        Justin Deoliveira added a comment -
        Marking this as won't fix. See GEOT-2577 for details, but basically since app-schema handles xlink and associations much nicer than the current jdbc-ng hacks, i think it makes sense to remove it, and just app-schema.
        Show
        Justin Deoliveira added a comment - Marking this as won't fix. See GEOT-2577 for details, but basically since app-schema handles xlink and associations much nicer than the current jdbc-ng hacks, i think it makes sense to remove it, and just app-schema.
        Hide
        Andrea Aime added a comment -
        Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
        Show
        Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

          People

          • Assignee:
            Justin Deoliveira
            Reporter:
            Andrea Aime
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: