have attribute descriptor user data contain native database type information

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.5.7, 2.6-M2
  • Component/s: jdbc
  • Labels:
    None

Description

For GEOT-2193 we need to know whether the type of the geometric column is "geometry" or "geographic" since they use different functions for interaction. The idea is to have JDBCDataStore include the native type name as user data. Similar to how it stores the native srid info.

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. GEOT-2193 have sql server support the geographic data type

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Bug - A problem which impairs or prevents the functions of the product. GEOT-2187 Check that database based datastores properly support case insensitive comparisons

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -
Andrea, any comments or thoughts on this one?
Show
Justin Deoliveira added a comment - Andrea, any comments or thoughts on this one?
Hide
Permalink
Andrea Aime added a comment -
Looks like a good idea, go ahead.
One thing that I'm thinking about is, where to draw the line between generically useful metadata and stuff that is needed by only one dialect. Actually this one seems useful in DB2 as well, but is a dialect allowed to customize the metadata somehow?
Show
Andrea Aime added a comment - Looks like a good idea, go ahead. One thing that I'm thinking about is, where to draw the line between generically useful metadata and stuff that is needed by only one dialect. Actually this one seems useful in DB2 as well, but is a dialect allowed to customize the metadata somehow?
Hide
Permalink
Justin Deoliveira added a comment -
Yeah, that could be an idea. Basically have a couple of callbacks after an attribute has been built and after a feature type has been built.

postAttributeCreate( AttributeDescriptor att, ResultSet columnMetadata );
postFeatureTypeCreate( FeatureType ft, ResultSet tableMetadata ):
Show
Justin Deoliveira added a comment - Yeah, that could be an idea. Basically have a couple of callbacks after an attribute has been built and after a feature type has been built. postAttributeCreate( AttributeDescriptor att, ResultSet columnMetadata ); postFeatureTypeCreate( FeatureType ft, ResultSet tableMetadata ):
Hide
Permalink
Justin Deoliveira added a comment -
Here is the patch for this (trunk), a review would be much appreciated.
Show
Justin Deoliveira added a comment - Here is the patch for this (trunk), a review would be much appreciated.
Hide
Permalink
Andrea Aime added a comment -
The patch looks good to me.
Show
Andrea Aime added a comment - The patch looks good to me.
Hide
Permalink
Christian Mueller added a comment -
"mvn clean install" for db2 shows SUCCESS
Show
Christian Mueller added a comment - "mvn clean install" for db2 shows SUCCESS
Hide
Permalink
Andrea Aime added a comment -
Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
Show
Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

People

  • Assignee:
    Justin Deoliveira
    Reporter:
    Justin Deoliveira
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: