GeoTools
  1. GeoTools
  2. GEOT-1922

Minimal Cleanup to FeatureCollection

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5-M2
    • Fix Version/s: 2.5.0
    • Component/s: main
    • Labels:
      None

      Description

      There is a really good proposal out on how to clean up FeatureCollection it covers several topics:

      • making FeatureCollection not implement java.util.Collection (this is required so we do not accidently allow people to use a for each loop)
      • throwing out unused methods from Collection
      • etc...

      We no longer have time to consider this entire proposal for the 2.5.0 release; but we do need to account for the first topic - not using java.util.Collection.

      The attached patch has the following changes:

      • ResourceCollection no longer extends Collection
      • ResourceCollection is method compatible with collection
      • DataUtilities.list( FeatureCollection ): List - used to adapt to a real collection for a few test cases (around 12 failures)
      • Isolating the two prepCollection and prepFeatureCollection methods in StreamingRenderer
      1. feature_collection_java5.patch
        34 kB
        Jody Garnett
      2. feature_collection_java5.patch
        32 kB
        Jody Garnett
      3. feature_collection_java5.patch
        29 kB
        Jody Garnett

        Activity

        Hide
        Jody Garnett added a comment -
        Updating the proposal:
        - http://docs.codehaus.org/display/GEOTOOLS/DataStore+Cleanup

        With the following tasks:

        GeoTools 2.5
        - FeatureCollection extends ResourceCollection does not extends java.util.Collection
        - Deprecate unused java.util.Collection methods left in ResourceCollection; as measued by not being implemented
        Show
        Jody Garnett added a comment - Updating the proposal: - http://docs.codehaus.org/display/GEOTOOLS/DataStore+Cleanup With the following tasks: GeoTools 2.5 - FeatureCollection extends ResourceCollection does not extends java.util.Collection - Deprecate unused java.util.Collection methods left in ResourceCollection; as measued by not being implemented
        Hide
        Jody Garnett added a comment -
        Patch applied on trunk -r31031
        Show
        Jody Garnett added a comment - Patch applied on trunk -r31031
        Hide
        Andrea Aime added a comment -
        Jody, it looks like this has been fixed? If so, please close
        Show
        Andrea Aime added a comment - Jody, it looks like this has been fixed? If so, please close
        Hide
        Andrea Aime added a comment -
        Jody, hasn't this been fixed?
        Show
        Andrea Aime added a comment - Jody, hasn't this been fixed?
        Hide
        Jody Garnett added a comment -
        Yes I believe this was fixed; the proposal only has items remaining for 2.6.x under its tasks...
        Show
        Jody Garnett added a comment - Yes I believe this was fixed; the proposal only has items remaining for 2.6.x under its tasks...

          People

          • Assignee:
            Unassigned
            Reporter:
            Jody Garnett
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: