GeoTools

FilterToSQLSDE broken on FilterCapabilities class cast exception

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: arcsde plugin, jdbc
  • Labels:
    None

Description

ArcSDE DataStore has gotten a lot of work recently; however it still breaks (right before my deadline):

java.lang.ClassCastException: net.refractions.udig.project.ui.internal.AdaptingFilter cannot be cast to org.geotools.filter.Filter
        at org.geotools.filter.Filters.getFilterType(Filters.java:220)
        at org.geotools.filter.FilterCapabilities.fullySupports(FilterCapabilities.java:387)
        at org.geotools.filter.FilterCapabilities.fullySupports(FilterCapabilities.java:397)
        at org.geotools.arcsde.filter.FilterToSQLSDE.encode(FilterToSQLSDE.java:198)
        at org.geotools.data.jdbc.FilterToSQL.encodeToString(FilterToSQL.java:211)
        at org.geotools.arcsde.data.ArcSDEQuery$FilterSet.getSeSqlConstruct(ArcSDEQuery.java:1014)
        at org.geotools.arcsde.data.ArcSDEQuery$FilterSet.getQueryInfo(ArcSDEQuery.java:935)
        at org.geotools.arcsde.data.ArcSDEQuery.calculateQueryExtent(ArcSDEQuery.java:651)
        at org.geotools.arcsde.data.ArcSDEQuery.calculateQueryExtent(ArcSDEQuery.java:554)
        at org.geotools.arcsde.data.ArcSdeFeatureSource.getBounds(ArcSdeFeatureSource.java:104)
        at org.geotools.arcsde.data.ArcSdeFeatureStore.getBounds(ArcSdeFeatureStore.java:159)
        at org.geotools.arcsde.data.ArcSdeFeatureSource.getBounds(ArcSdeFeatureSource.java:69)
        at org.geotools.data.view.DefaultView.getBounds(DefaultView.java:516)

The filter being passed in is:

public class AdaptingFilter implements Filter, IAdaptable {

    final private Filter wrapped;
    ...
	public Object accept(FilterVisitor visitor, Object extraData) {
		return wrapped.accept(visitor, extraData);
	}

	public boolean evaluate(Object object) {
		return wrapped.evaluate(object);
	}
}

So what we have here is a conflict over the nature of the Filter interface.

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. GEOT-1637 Use of FilterCapabilities

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.
is superceded by

Improvement - An improvement or enhancement to an existing feature or task. GEOT-1637 Use of FilterCapabilities

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
Fixing the uDig side of the fence to produce specific wrapper for specific filter interfaces: ie AdaptingOr, AdaptingAnd, AdaptingBeyong ...
Show
Jody Garnett added a comment - Fixing the uDig side of the fence to produce specific wrapper for specific filter interfaces: ie AdaptingOr, AdaptingAnd, AdaptingBeyong ...
Hide
Permalink
Jody Garnett added a comment -
Ends up that FilterToSQL is set up fine; but makes use of FilterCapabilties which is still set up against geotools filter. I have had enough waiting ... time to hack.
Show
Jody Garnett added a comment - Ends up that FilterToSQL is set up fine; but makes use of FilterCapabilties which is still set up against geotools filter. I have had enough waiting ... time to hack.
Hide
Permalink
Jody Garnett added a comment - - edited
Found the Filters.getFilterType( org.opengis.Filter filter ) method had mistake in some optimization code that was tripping things up.

BEFORE:
        if( filter instanceof Filter) {
            return ((org.geotools.filter.Filter)filter).getFilterType(); // UNSAFE CAST
        }
        if( filter instanceof PropertyIsBetween ) return FilterType.BETWEEN;
        ....
        return 0;

FIXED:
        if( filter instanceof org.geotools.filter.Filter){
            return ((org.geotools.filter.Filter)filter).getFilterType(); // SAFE CAST
        }
        if( filter instanceof PropertyIsBetween ) return FilterType.BETWEEN;
        ....
        return 0;
Show
Jody Garnett added a comment - - edited Found the Filters.getFilterType( org.opengis.Filter filter ) method had mistake in some optimization code that was tripping things up. BEFORE:         if( filter instanceof Filter) {             return ((org.geotools.filter.Filter)filter).getFilterType(); // UNSAFE CAST         }         if( filter instanceof PropertyIsBetween ) return FilterType.BETWEEN;         ....         return 0; FIXED:         if( filter instanceof org.geotools.filter.Filter){             return ((org.geotools.filter.Filter)filter).getFilterType(); // SAFE CAST         }         if( filter instanceof PropertyIsBetween ) return FilterType.BETWEEN;         ....         return 0;

People

  • Assignee:
    Gabriel Roldan
    Reporter:
    Jody Garnett
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: