GeoTools

ProcessStylers should close FeatureReaders

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.7-M0
  • Component/s: render
  • Labels:
    None

Description

LiteRenderer.processStylers() does open FeatureReaders but forgets
to close them... this should really be added as it is a potential source of resource leaks.

Also, improve the robustness of RenderedLayerFactory on FeatureReader closing, should be done in a finally block to avoid
resource leaks on rendered layer setup exceptions.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. GEOS-163 Transaction being left open

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
Hi Jesse you probably want to check this out? I will wait on the 2.0.M1 release untill I hear from you.
Show
Jody Garnett added a comment - Hi Jesse you probably want to check this out? I will wait on the 2.0.M1 release untill I hear from you.
Hide
Permalink
Jesse Eichar added a comment -
Changed my mind still could happen in extreme cases.
Show
Jesse Eichar added a comment - Changed my mind still could happen in extreme cases.
Hide
Permalink
Andrea Aime added a comment -
This one has been fixed time ago, made extra sure one cannot get out without closing the iterators (readers usage is long gone)
Show
Andrea Aime added a comment - This one has been fixed time ago, made extra sure one cannot get out without closing the iterators (readers usage is long gone)

People

  • Assignee:
    Jesse Eichar
    Reporter:
    Andrea Aime
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: