[#GEOT-1520] Add a dispose method to the datastore API

GeoTools

Add a dispose method to the datastore API

Created: 17/Oct/07 02:58 AM Updated: Thursday 08:04 PM

Component/s:

data

Affects Version/s:

2.5-M0, 2.4-RC0

Fix Version/s:

2.4.6

Issue Links:

Supercedes

This issue supercedes:

~~GEOT-126~~ Define and implement a shutdown strategy for datastores

dependent

This issue is depended upon by:

GEOT-950 PostgisDataStore does not close connection pool on disposal

Sub-Tasks:

All

Open

1.	~~Add DataStore.dispose() and fix common implementations~~	Closed	Andrea Aime
2.	~~Code a proper dispose for ArcSDEDataStore~~	Closed	Gabriel Roldán
3.	Update documentation	Open	Andrea Aime
4.	Update demo code so that dispose() is used	Open	Andrea Aime

Description

« Hide

See the proposal at:
http://docs.codehaus.org/display/GEOTOOLS/Add+a+dispose+method+to+DataStore+API

All

Comments

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Jody Garnett - 17/Oct/07 11:45 AM

Can we do our trick where non closed datastores produce a warning message in the logs?

[ Permlink | « Hide ]

Andrea Aime - 17/Oct/07 12:29 PM

Makes sense... but only for the datastores that need it, or do you want to enforce it as a best practice and complain even in the ones that do not need closing?