GeoTools

GeoToolsFactory renamed to ReferencingObjectFactory

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.4-M3
  • Fix Version/s: 2.4-M4
  • Component/s: referencing
  • Labels:
    None

Description

This one name has caused lots of confusion, almost every newbie trips on this one at least once. The actual class is the "GeoTools" implementation the following:

  • CSFactory
  • DatumFactory
  • CRSFactory

Each of these interface is responsible for producing some components of the GeoAPI referencing model. They are real factories and do create objects with no logic. Strictly speaking no definition, they do have some logic in the form of CanconicalSet used to intern objects so the factory does not let duplicates out into the wild.

The class is also marked with the BufferedFactory marker interface (not sure why, maybe for for the reporting tool).

Issue Links

relates to

Sub-task - The sub-task of the issue GEOT-1300 Isolate CanonicalSet as a subclass of WeakHashSet

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Jody Garnett made changes -
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Jody Garnett added a comment -
The instances created are actually extensions of: org.opengis.referencing.IdentifiedObject.

Going to ask around and see if IdentifiedObjectFactory would be more appropriate.
Show
Jody Garnett added a comment - The instances created are actually extensions of: org.opengis.referencing.IdentifiedObject. Going to ask around and see if IdentifiedObjectFactory would be more appropriate.
Hide
Permalink
Martin Desruisseaux added a comment -
I agree with this name change proposal, both ReferencingObjectFactory and IdentifiedObjectFactory. I have a slight preference for ReferencingObjectFactory.

This factory implements the BufferedFactory marker interface for reporting that it provides some sort of caching. This is not real caching however since it just tries to avoid duplicated objects, so maybe BufferedFactory is not appropriate. It has no impact on execution however.
Show
Martin Desruisseaux added a comment - I agree with this name change proposal, both ReferencingObjectFactory and IdentifiedObjectFactory. I have a slight preference for ReferencingObjectFactory. This factory implements the BufferedFactory marker interface for reporting that it provides some sort of caching. This is not real caching however since it just tries to avoid duplicated objects, so maybe BufferedFactory is not appropriate. It has no impact on execution however.
Martin Desruisseaux made changes -
Link This issue relates to GEOT-1300 [ GEOT-1300 ]
Hide
Permalink
Jody Garnett added a comment -
Changed as of svn revision 25888.
Show
Jody Garnett added a comment - Changed as of svn revision 25888.
Jody Garnett made changes -
Status In Progress [ 3 ] Closed [ 6 ]
Fix Version/s 2.4-M4 [ 13525 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Jody Garnett added a comment -
restored history -r 25919
Show
Jody Garnett added a comment - restored history -r 25919

People

  • Assignee:
    Jody Garnett
    Reporter:
    Jody Garnett
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: