jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
GeoTools
  • GeoTools
  • GEOT-1286 Add Concurrency Support to CRS Authority
  • GEOT-1300

Isolate CanonicalSet as a subclass of WeakHashSet

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.4-M3
  • Fix Version/s: 2.4-M4
  • Component/s: referencing
  • Labels:
    None

Description

WeakHashSet is currently pulling double duty:

  • It functions as a normal set that happens to store its entries using WeakReferences
  • it has additional methods (ie canonicalize) in order to function in a manner similar to String.intern

We should seperate these two concerns - primarily so what is going on can be understood.

  • WeakHashSet - remains as set of weak references, methods providing additional functionality will be deprecated
  • CanonicalSet cerated as an extension to WeakHashSet and proivdes a unique method

This bug report is done when we have updated the code and provided user docs on the result.

Sample use:

class FooFactory {
    public Foo create(String definition) {
          Foo created = new Foo(definition);
          return (Foo) canionicalSet.unique(created);
    }
}

Issue Links

is related to

Sub-task - The sub-task of the issue GEOT-1301 GeoToolsFactory renamed to ReferencingObjectFactory

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • History
  • Activity
Jody Garnett made changes - 12/Jun/07 2:19 PM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Jody Garnett made changes - 12/Jun/07 2:31 PM
Status In Progress [ 3 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Martin Desruisseaux made changes - 13/Jun/07 9:29 AM
Link This issue is related to GEOT-1301 [ GEOT-1301 ]
Jody Garnett made changes - 13/Jun/07 12:02 PM
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Jody Garnett made changes - 13/Jun/07 12:08 PM
Summary WeakHashSet renamed to CanonicalSet Isolate CanonicalSet as a subclass of WeakHashSet
Description WeakHashSet just deprecated for now, simply extends CanonicalSet which is its replacement. We need to rename any associated test case as well. WeakHashSet is currently pulling double duty:
- It functions as a normal set that happens to store its entries using WeakReferences
- it has additional methods (ie canonicalize) in order to function in a manner similar to String.intern

We should seperate these two concerns - primarly so what is going on can be understood.

- WeakHashSet - remains as set of weak references, methods providing additional functionality will be deprecated
- CanonicalSet cerated as an extention to WeakHashSet and proivdes a toUnique method

This bug report is done when we have updated the code and provided user docs on the result.

Sample use:
{code}
class FooFactory {
    public Foo create(String definition) {
          Foo created = new Foo(definition);
          return (Foo) canionicalSet.toUnique(created);
    }
}
{code}
Jody Garnett made changes - 18/Jun/07 12:23 PM
Description WeakHashSet is currently pulling double duty:
- It functions as a normal set that happens to store its entries using WeakReferences
- it has additional methods (ie canonicalize) in order to function in a manner similar to String.intern

We should seperate these two concerns - primarly so what is going on can be understood.

- WeakHashSet - remains as set of weak references, methods providing additional functionality will be deprecated
- CanonicalSet cerated as an extention to WeakHashSet and proivdes a toUnique method

This bug report is done when we have updated the code and provided user docs on the result.

Sample use:
{code}
class FooFactory {
    public Foo create(String definition) {
          Foo created = new Foo(definition);
          return (Foo) canionicalSet.toUnique(created);
    }
}
{code}
WeakHashSet is currently pulling double duty:
- It functions as a normal set that happens to store its entries using WeakReferences
- it has additional methods (ie canonicalize) in order to function in a manner similar to String.intern

We should seperate these two concerns - primarly so what is going on can be understood.

- WeakHashSet - remains as set of weak references, methods providing additional functionality will be deprecated
- CanonicalSet cerated as an extention to WeakHashSet and proivdes a toUnique method

This bug report is done when we have updated the code and provided user docs on the result.

Sample use:
{code}
class FooFactory {
    public Foo create(String definition) {
          Foo created = new Foo(definition);
          return (Foo) canionicalSet.unique(created);
    }
}
{code}
Jody Garnett made changes - 18/Jun/07 12:24 PM
Description WeakHashSet is currently pulling double duty:
- It functions as a normal set that happens to store its entries using WeakReferences
- it has additional methods (ie canonicalize) in order to function in a manner similar to String.intern

We should seperate these two concerns - primarly so what is going on can be understood.

- WeakHashSet - remains as set of weak references, methods providing additional functionality will be deprecated
- CanonicalSet cerated as an extention to WeakHashSet and proivdes a toUnique method

This bug report is done when we have updated the code and provided user docs on the result.

Sample use:
{code}
class FooFactory {
    public Foo create(String definition) {
          Foo created = new Foo(definition);
          return (Foo) canionicalSet.unique(created);
    }
}
{code}
WeakHashSet is currently pulling double duty:
- It functions as a normal set that happens to store its entries using WeakReferences
- it has additional methods (ie canonicalize) in order to function in a manner similar to String.intern

We should seperate these two concerns - primarily so what is going on can be understood.

- WeakHashSet - remains as set of weak references, methods providing additional functionality will be deprecated
- CanonicalSet cerated as an extension to WeakHashSet and proivdes a *unique* method

This bug report is done when we have updated the code and provided user docs on the result.

Sample use:
{code}
class FooFactory {
    public Foo create(String definition) {
          Foo created = new Foo(definition);
          return (Foo) canionicalSet.unique(created);
    }
}
{code}
Jody Garnett made changes - 18/Jun/07 12:25 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]
Martin Desruisseaux made changes - 07/Jul/07 5:54 AM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Martin Desruisseaux made changes - 07/Jul/07 5:54 AM
Affects Version/s 2.4-M3 [ 13451 ]
Martin Desruisseaux made changes - 07/Jul/07 5:54 AM
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Jody Garnett
    Reporter:
    Jody Garnett
Vote (0)
Watch (1)

Dates

  • Created:
    12/Jun/07 2:19 PM
    Updated:
    07/Jul/07 5:54 AM
    Resolved:
    07/Jul/07 5:54 AM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.