GeoTools
  1. GeoTools
  2. GEOT-1038 Most FunctionExpression's are broken
  3. GEOT-1287

Most FunctionExpression's are broken - Applying the same solution done to the trunk

    Details

    • Type: Sub-task Sub-task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.2.3
    • Component/s: cql
    • Labels:
      None

      Description

      Applying the same solution done to the trunk

      Patch Description:

      Basically the problem is that since all the function implementations implement
      both geoapi and geotoos function interfaces, they're not synchronized in
      order to behave correctly whether one or the other is used

      1- a new constructor to set the function name, since some functions, though
      extending AbstractFunctionImpl, were returning null in getName
              function_x()
                      super("X");

      2- new method setParameters and List getParameters
      This change implies  that setArgs delegates in setParamenters to set the
      instance variable that maintains the parameters (or arguments) in a
      ArrayList; as a bunch of functions were storing the arguments by themselves
      but getArgs/getParameters and setArgs/setParameters were inconsistent

      3- specific setting method to update parameters like setExpression was changed
      to taking into account the new parameters allocation (ArrayList)

      4- new method evaluate()  that implements the function evaluation delegating
      in the old getValue(), as much of them did not implement evaluate.

      5- Additionaly, a new test was added to assure that the new and the old
      interface go well: org.geotools.filter.FunctionExpressionImplTest

      1. GEOT-1038-src-brewer-2.3.x.patch
        0.6 kB
        Mauricio Pazos
      2. GEOT-1038-src-main-2.3.x.patch
        580 kB
        Mauricio Pazos

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Mauricio Pazos
            Reporter:
            Mauricio Pazos
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: