GeoTools
  1. GeoTools
  2. GEOT-1050

fid attribute is 'missing' as a feature-attribute

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.2.1, 2.3.M0
    • Fix Version/s: 2.3.1, 2.4-M2
    • Component/s: arcsde plugin
    • Labels:
      None

      Description

      Suppose one had an attribute "OBJECTID" on one's arcsde table, and that arcsde was using OBJECTID as an sde-managed rowid column.

      When querying this featurecollection for all attributes on each feature, you'll be missing the OBJECTID attribute on your returned feature. It's value will be stuck in the "fid" field, but it'll still be missing from the attribute list on each returned feature.

      This causes schema invalidity and some funkiness in geoserver. Attached (one-line) patch fixes this issue by having the featureIdField appear both in the fid field and in the list of output attributes.

      Patches for 2.2.x, 2.3.x and trunk (2.4.x) attached.

      1. get-featid-attrs-too.2.2.x.patch
        0.6 kB
        Saul Farber
      2. get-featid-attrs-too.2.3.x.patch
        0.6 kB
        Saul Farber
      3. get-featid-attrs-too.gt-trunk.patch
        0.7 kB
        Saul Farber

        Activity

        Hide
        Gabriel Roldan added a comment -
        Saul, I'm not sure the arcsde managed row-id column should appear as a normal attribute. At least as long as its value is automatically added by arcsde on an insert.

        What do you mean by causing schema invalidity?

        Also, if you could take an hour, would you be so kind of taking a look at the stuff in the geotools complex-features branch that allows arcsde plugin to have different fid strategies based on how the table is settled up? I would very like your impression about that, since I'm planning to port it to trunk on my vacation week next month
        Show
        Gabriel Roldan added a comment - Saul, I'm not sure the arcsde managed row-id column should appear as a normal attribute. At least as long as its value is automatically added by arcsde on an insert. What do you mean by causing schema invalidity? Also, if you could take an hour, would you be so kind of taking a look at the stuff in the geotools complex-features branch that allows arcsde plugin to have different fid strategies based on how the table is settled up? I would very like your impression about that, since I'm planning to port it to trunk on my vacation week next month
        Hide
        Jody Garnett added a comment -
        Agreed this is by design; there is nothing preventing you from producing a feature id based on the value of some attributes - but please be sure to make sure those attributes cannot be set for stability etc...
        Show
        Jody Garnett added a comment - Agreed this is by design; there is nothing preventing you from producing a feature id based on the value of some attributes - but please be sure to make sure those attributes cannot be set for stability etc...
        Hide
        Gabriel Roldan added a comment -
        so applying this patch is denied as it will be better to port the FIDReader stuff from complex-features branch
        Show
        Gabriel Roldan added a comment - so applying this patch is denied as it will be better to port the FIDReader stuff from complex-features branch
        Hide
        Saul Farber added a comment -
        See comments. Won't fix because we want to port the FIDReader from the complex-feature branch.
        Show
        Saul Farber added a comment - See comments. Won't fix because we want to port the FIDReader from the complex-feature branch.
        Hide
        Andrea Aime added a comment -
        Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update
        Show
        Andrea Aime added a comment - Mass closing all issues that have been in "resolved" state for 2 months or more without any feedback or update

          People

          • Assignee:
            Gabriel Roldan
            Reporter:
            Saul Farber
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: