GeoServer

GeoServer security subsytem fails to migrate previously valid user names

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.2-RC3, 2.3-beta1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The xml dumper fails to migrate names that are not valid NCName, which were previously valid and not in uncommon usage:
3abc
user@organization.it

This is a backward incompatible change, so it's a regression

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Aime added a comment - 
java.lang.RuntimeException: java.io.IOException: org.xml.sax.SAXParseException; cvc-datatype-valid.1.2.1: '3rdUSer' is not a valid value for 'NCName'.
	at org.geoserver.security.GeoServerSecurityManager.onApplicationEvent(GeoServerSecurityManager.java:290)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:97)
	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:324)
	at org.geoserver.platform.GeoServerContextLoaderListener.contextInitialized(GeoServerContextLoaderListener.java:21)
	at org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:540)
	at org.mortbay.jetty.servlet.Context.startContext(Context.java:135)
	at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1220)
	at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:510)
	at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:448)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:39)
	at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
	at org.mortbay.jetty.Server.doStart(Server.java:222)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:39)
	at org.geoserver.web.Start.main(Start.java:116)
Caused by: java.io.IOException: org.xml.sax.SAXParseException; cvc-datatype-valid.1.2.1: '3rdUSer' is not a valid value for 'NCName'.
	at org.geoserver.security.xml.XMLValidator.validateUserGroupRegistry(XMLValidator.java:66)
	at org.geoserver.security.xml.XMLUserGroupService.deserialize(XMLUserGroupService.java:150)
	at org.geoserver.security.impl.AbstractUserGroupService.load(AbstractUserGroupService.java:152)
	at org.geoserver.security.impl.AbstractUserGroupStore.store(AbstractUserGroupStore.java:293)
	at org.geoserver.security.xml.XMLUserGroupStore.store(XMLUserGroupStore.java:220)
	at org.geoserver.security.concurrent.LockingUserGroupStore.store(LockingUserGroupStore.java:130)
	at org.geoserver.security.GeoServerSecurityManager.migrateIfNecessary(GeoServerSecurityManager.java:2036)
	at org.geoserver.security.GeoServerSecurityManager.onApplicationEvent(GeoServerSecurityManager.java:288)
	... 13 more
Caused by: org.xml.sax.SAXParseException; cvc-datatype-valid.1.2.1: '3rdUSer' is not a valid value for 'NCName'.
	at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)
	at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown Source)
	at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
	at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
	at org.apache.xerces.impl.xs.XMLSchemaValidator$XSIErrorReporter.reportError(Unknown Source)
	at org.apache.xerces.impl.xs.XMLSchemaValidator.reportSchemaError(Unknown Source)
	at org.apache.xerces.impl.xs.XMLSchemaValidator.processOneAttribute(Unknown Source)
	at org.apache.xerces.impl.xs.XMLSchemaValidator.processAttributes(Unknown Source)
	at org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown Source)
	at org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
	at org.apache.xerces.jaxp.validation.DOMValidatorHelper.beginNode(Unknown Source)
	at org.apache.xerces.jaxp.validation.DOMValidatorHelper.validate(Unknown Source)
	at org.apache.xerces.jaxp.validation.DOMValidatorHelper.validate(Unknown Source)
	at org.apache.xerces.jaxp.validation.ValidatorImpl.validate(Unknown Source)
	at javax.xml.validation.Validator.validate(Validator.java:124)
	at org.geoserver.security.xml.XMLValidator.validateUserGroupRegistry(XMLValidator.java:64)
	... 20 more
Show
Andrea Aime added a comment - java.lang.RuntimeException: java.io.IOException: org.xml.sax.SAXParseException; cvc-datatype-valid.1.2.1: '3rdUSer' is not a valid value for 'NCName'. at org.geoserver.security.GeoServerSecurityManager.onApplicationEvent(GeoServerSecurityManager.java:290) at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:97) at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:324) at org.geoserver.platform.GeoServerContextLoaderListener.contextInitialized(GeoServerContextLoaderListener.java:21) at org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:540) at org.mortbay.jetty.servlet.Context.startContext(Context.java:135) at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1220) at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:510) at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:448) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:39) at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) at org.mortbay.jetty.Server.doStart(Server.java:222) at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:39) at org.geoserver.web.Start.main(Start.java:116) Caused by: java.io.IOException: org.xml.sax.SAXParseException; cvc-datatype-valid.1.2.1: '3rdUSer' is not a valid value for 'NCName'. at org.geoserver.security.xml.XMLValidator.validateUserGroupRegistry(XMLValidator.java:66) at org.geoserver.security.xml.XMLUserGroupService.deserialize(XMLUserGroupService.java:150) at org.geoserver.security.impl.AbstractUserGroupService.load(AbstractUserGroupService.java:152) at org.geoserver.security.impl.AbstractUserGroupStore.store(AbstractUserGroupStore.java:293) at org.geoserver.security.xml.XMLUserGroupStore.store(XMLUserGroupStore.java:220) at org.geoserver.security.concurrent.LockingUserGroupStore.store(LockingUserGroupStore.java:130) at org.geoserver.security.GeoServerSecurityManager.migrateIfNecessary(GeoServerSecurityManager.java:2036) at org.geoserver.security.GeoServerSecurityManager.onApplicationEvent(GeoServerSecurityManager.java:288) ... 13 more Caused by: org.xml.sax.SAXParseException; cvc-datatype-valid.1.2.1: '3rdUSer' is not a valid value for 'NCName'. at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source) at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown Source) at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) at org.apache.xerces.impl.xs.XMLSchemaValidator$XSIErrorReporter.reportError(Unknown Source) at org.apache.xerces.impl.xs.XMLSchemaValidator.reportSchemaError(Unknown Source) at org.apache.xerces.impl.xs.XMLSchemaValidator.processOneAttribute(Unknown Source) at org.apache.xerces.impl.xs.XMLSchemaValidator.processAttributes(Unknown Source) at org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown Source) at org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source) at org.apache.xerces.jaxp.validation.DOMValidatorHelper.beginNode(Unknown Source) at org.apache.xerces.jaxp.validation.DOMValidatorHelper.validate(Unknown Source) at org.apache.xerces.jaxp.validation.DOMValidatorHelper.validate(Unknown Source) at org.apache.xerces.jaxp.validation.ValidatorImpl.validate(Unknown Source) at javax.xml.validation.Validator.validate(Validator.java:124) at org.geoserver.security.xml.XMLValidator.validateUserGroupRegistry(XMLValidator.java:64) ... 20 more
Hide
Permalink
Andrea Aime added a comment -

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

Show
Andrea Aime added a comment - Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

People

  • Assignee:
    Christian Mueller
    Reporter:
    Andrea Aime
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: