GeoServer

Tighten type constraints in AuthenticationFilterPanel

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2-RC1
  • Fix Version/s: 2.2-RC3
  • Component/s: Security, Wicket UI
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

As discussed on the mailing list:

Looks like the system allows for configuring more than just authentication filters, and those extras are configured but not displayed in the configuration GUI. There's already a constraint on the type parameter for AuthenticationFilterPanel, but it requires SecurityFilterConfig. I think it would be helpful to future plugin developers if this constraint required SecurityAuthFilterConfig (which is just a marker interface) instead. In fact the web UI breaks if this marker interface is not present, but only on the filter list.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Deoliveira added a comment -

Looks good to me. Just to be sure, all the default filter panels still show up with this patch correct? And perhaps you can verify that they all still show up when they are clicked on? If that holds then I say go ahead and commit.

Show
Justin Deoliveira added a comment - Looks good to me. Just to be sure, all the default filter panels still show up with this patch correct? And perhaps you can verify that they all still show up when they are clicked on? If that holds then I say go ahead and commit.
Hide
Permalink
David Winslow added a comment -

Yep, all the default filter panels still show up. This change only affects a type constraint, which thanks to Java's type erasure doesn't mean much at runtime – I'm pretty confident that this change is safe since nothing else needed to be changed to make the compiler happy. Still, when I was running through I did find an unrelated issue (https://github.com/geoserver/geoserver/commit/612d019d6025d96c0c918778de4f2e980492bc69) which I went ahead and fixed, so good thing I did the more intensive testing.

Show
David Winslow added a comment - Yep, all the default filter panels still show up. This change only affects a type constraint, which thanks to Java's type erasure doesn't mean much at runtime – I'm pretty confident that this change is safe since nothing else needed to be changed to make the compiler happy. Still, when I was running through I did find an unrelated issue ( https://github.com/geoserver/geoserver/commit/612d019d6025d96c0c918778de4f2e980492bc69 ) which I went ahead and fixed, so good thing I did the more intensive testing.
Hide
Permalink
Andrea Aime added a comment -

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

Show
Andrea Aime added a comment - Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status

People

  • Assignee:
    David Winslow
    Reporter:
    David Winslow
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: