Details
Description
The new security password provider is broken in any data directory that contains special characters such as spaces, causing the build to fail:
Tests in error: testEncryption(org.geoserver.security.password.URLMasterPasswordProviderTest): /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/target/passwd1191987093163736111tmp (No such file or directory) testMasterPasswordChange(org.geoserver.security.password.MasterPasswordChangeTest): java.io.FileNotFoundException: /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/./target/mock2049237527189537102data/security/mpw1.properties (No such file or directory)
Deployments will also be affected. The underlying problem is code like:
File f = new File(url.getFile());
in URLMasterpasswordProvider that does not use DataUtilities as required by the project conventions:
http://docs.geotools.org/latest/developer/conventions/code/url.html
Activity
Ben Caradoc-Davies
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Andrea Aime [ aaime ] | Justin Deoliveira [ jdeolive ] |
Ben Caradoc-Davies
made changes -
| Attachment | GEOS-5041.patch [ 59513 ] |
Ben Caradoc-Davies
made changes -
| Description |
Th new security password provider is broken in any data directory that contains special characters such as spaces, causing the build to fail:
{noformat} Tests in error: testEncryption(org.geoserver.security.password.URLMasterPasswordProviderTest): /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/target/passwd1191987093163736111tmp (No such file or directory) testMasterPasswordChange(org.geoserver.security.password.MasterPasswordChangeTest): java.io.FileNotFoundException: /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/./target/mock2049237527189537102data/security/mpw1.properties (No such file or directory) {noformat} Deployments will also be affected. The underlying problem is code like: {noformat} File f = new File(url.getFile()); {noformat} in URLMasterpasswordProvider that does not use DataUtilities as required by the project conventions: http://docs.geotools.org/latest/developer/conventions/code/url.html |
The new security password provider is broken in any data directory that contains special characters such as spaces, causing the build to fail:
{noformat} Tests in error: testEncryption(org.geoserver.security.password.URLMasterPasswordProviderTest): /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/target/passwd1191987093163736111tmp (No such file or directory) testMasterPasswordChange(org.geoserver.security.password.MasterPasswordChangeTest): java.io.FileNotFoundException: /home/car605/geoserver/src%20with%20spaces/geoserver-trunk/src/main/./target/mock2049237527189537102data/security/mpw1.properties (No such file or directory) {noformat} Deployments will also be affected. The underlying problem is code like: {noformat} File f = new File(url.getFile()); {noformat} in URLMasterpasswordProvider that does not use DataUtilities as required by the project conventions: http://docs.geotools.org/latest/developer/conventions/code/url.html |
Ben Caradoc-Davies
made changes -
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Ben Caradoc-Davies
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Ben Caradoc-Davies
made changes -
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Assignee | Justin Deoliveira [ jdeolive ] | Ben Caradoc-Davies [ bencaradocdavies ] |
Ben Caradoc-Davies
made changes -
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Fix Version/s | 2.2.x [ 17106 ] | |
| Fix Version/s | 2.2-beta2 [ 18437 ] | |
| Resolution | Fixed [ 1 ] |
Andrea Aime
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Justin, there was a time when you configured Hudson to build in a path with spaces. I think that was a great way of catching problems like this.