Broken File/URL conversions in security

Justin, there was a time when you configured Hudson to build in a path with spaces. I think that was a great way of catching problems like this.

Justin, please find attached a patch that fixes these failures.

Note that I may have been a bit aggressive in my use of getCanonicalFile in MasterPasswordChangeTest (the test passes both with and without them); this may reduce your test coverage of relative file URLs for password provider configuration. I am not quite sure of your intent in these tests. By comparison, in URLMasterPasswordProviderTest you explicitly canonicalise the file path before using it. Different code paths will be used for relative and absolute paths, with and without a protocol.

Even with this patch I also see multiple test failures in jdbc-sec. Might need another Jira issue:

Results :

Failed tests:
testConfiguration(org.geoserver.security.jdbc.H2UserDetailsServiceTest): org.h2.jdbc.JdbcSQLException: Table USERS already exists; SQL statement:
create table users(name varchar(128) not null,password varchar(254), enabled char(1) not null, primary key(name)) [42101-119]

Tests in error:
testWrapRoleService(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): org.h2.jdbc.JdbcSQLException: Unique index or primary key violation: PRIMARY_KEY_7 ON PUBLIC.GROUPS(NAME); SQL statement:
insert into groups(name ,enabled) values (?,?) [23001-119]
testWrapUserGroupService(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testHideAdminRole(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testHideGroups(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testRoleServiceReadOnly(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testCreateNewUser(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testAssignUserToGroup(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testRemoveUserInGroup(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testRemoveUserNotInGroup(org.geoserver.security.jdbc.JDBCGroupAdminServiceTest): User/group service gaugs already exists
testRoleDatabaseSetup(org.geoserver.security.jdbc.DB2RoleServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testRemove(org.geoserver.security.jdbc.DB2RoleServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testInsert(org.geoserver.security.jdbc.DB2RoleServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testModify(org.geoserver.security.jdbc.DB2RoleServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testIsModified(org.geoserver.security.jdbc.DB2RoleServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testUserGroupDatabaseSetup(org.geoserver.security.jdbc.PostGisUserGroupServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testRemove(org.geoserver.security.jdbc.PostGisUserGroupServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testInsert(org.geoserver.security.jdbc.PostGisUserGroupServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testModify(org.geoserver.security.jdbc.PostGisUserGroupServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testIsModified(org.geoserver.security.jdbc.PostGisUserGroupServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity
testEmptyPassword(org.geoserver.security.jdbc.PostGisUserGroupServiceTest): org.geoserver.data.test.LiveData cannot be cast to org.geoserver.security.jdbc.LiveDbmsDataSecurity

Looks good to me Ben, commit these fixes as you please. Also feel free to just commit the fixes in the jdbc security module. As for the master password change test i do believe the intension is to test with a relative fiel url... so if we can maintain that it would be ideal.

OK, will do. Looks like the jdbc-sec failures are in Maven3 only (32 and 64 bit). I am running tests with Maven 2 to confirm they all pass and then will commit the patch (removing my added getCanonicalFiles in MasterPasswordChangeTest). I will raise the Maven 3 failures as a separate issue.

Committed in r16912 on trunk (with the two added getCanonicalFiles in MasterPasswordChangeTest omitted as requested).

Fixed.

The sec-jdbc failures are GEOS-5043.

Switching all issues that have been in "resolved" state for more than one month without further comments to "closed" status