jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • GeoServer
  • GEOS-4956

WMS time extent does not properly encode dates with negative years

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.4
  • Fix Version/s: 2.2-beta1
  • Component/s: WMS
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes

Description

java.util.Date supports representation of dates between -296,000,000 to 296,000,000 years.

The current implementation of date output in the getcapabilities response for time extent does not properly encode these values according to the WMS specification (section D2.2, pp 57-58).

Attached patch ensures this with a new formatter (SimpleDateFormat cannot support this format directly) and verifies compliance with the extended ISO8601 format in the TimeKvpParserTest.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    fix-wms-time-extent2.patch
    11/Feb/12 10:30 AM
    10 kB
    Ian Schneider

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Andrea Aime added a comment - 11/Feb/12 4:10 AM

As far as I can see it looks good, but it adds code doing the proper formatting of dates without testing it (the test is for the parsing, but there is no testing for the capabilities document contents)

Show
Andrea Aime added a comment - 11/Feb/12 4:10 AM As far as I can see it looks good, but it adds code doing the proper formatting of dates without testing it (the test is for the parsing, but there is no testing for the capabilities document contents)
Hide
Permalink
Ian Schneider added a comment - 11/Feb/12 10:30 AM

Not sure how that didn't make it in... Test included in new patch.

Show
Ian Schneider added a comment - 11/Feb/12 10:30 AM Not sure how that didn't make it in... Test included in new patch.
Hide
Permalink
Andrea Aime added a comment - 11/Feb/12 2:28 PM

Nice, +1

Show
Andrea Aime added a comment - 11/Feb/12 2:28 PM Nice, +1
Hide
Permalink
Ian Schneider added a comment - 15/Feb/12 3:01 PM

Fixed in r16770

Show
Ian Schneider added a comment - 15/Feb/12 3:01 PM Fixed in r16770

People

  • Assignee:
    Ian Schneider
    Reporter:
    Ian Schneider
Vote (0)
Watch (2)

Dates

  • Created:
    09/Feb/12 3:19 PM
    Updated:
    04/Apr/12 9:13 PM
    Resolved:
    15/Feb/12 3:01 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.