GeoServer

GetLegendGraphic urls in WMS GetCapabilities miss STYLE parameter

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: WMS
  • Labels:
  • Number of attachments :
    0

Description

INSPIRE demands a named style called inspire_common:DEFAULT, which needs to be simple black lines etc. This makes it likely that people will need to set up multiple styles for a layer, also a more meaningful style.

However, the LegendURL advertized in the GeoServer WMS GetCapabilities response does not output the STYLE parameter, so all legends will show up with the default style. It should be sufficient to add the STYLE parameter to the advertized LegendURL.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gabriel Roldan added a comment -

But it still makes sense that the LegendURL in the getcaps doc points to the layer's default style. So I wonder what is the issue really. Does INSPIRE mandate that the default style for all layers is inspire_common:DEFAULT? or just that such style exists?

So if we add the STYLE parameter to the getcaps advertised LegendURL that would change the meaning of the LegendURL if using a style different than the default one, right? and if inspire_common:DEFAULT has to be the default for all layers then that's a different issue and changing the LegendURL to include STYLE would make no difference?

Show
Gabriel Roldan added a comment - But it still makes sense that the LegendURL in the getcaps doc points to the layer's default style. So I wonder what is the issue really. Does INSPIRE mandate that the default style for all layers is inspire_common:DEFAULT? or just that such style exists? So if we add the STYLE parameter to the getcaps advertised LegendURL that would change the meaning of the LegendURL if using a style different than the default one, right? and if inspire_common:DEFAULT has to be the default for all layers then that's a different issue and changing the LegendURL to include STYLE would make no difference?
Hide
Permalink
Bart van den Eijnden added a comment -

Hi Gabriel, the issue I raised is here is about LegendURL always pointing to the default style, it should point to the legend graphic for the corresponding Style.

Show
Bart van den Eijnden added a comment - Hi Gabriel, the issue I raised is here is about LegendURL always pointing to the default style, it should point to the legend graphic for the corresponding Style.
Hide
Permalink
Bart van den Eijnden added a comment -

To be clear, there is a LegendURL per Style, it's not one global LegendURL for a Layer.

Show
Bart van den Eijnden added a comment - To be clear, there is a LegendURL per Style, it's not one global LegendURL for a Layer.
Hide
Permalink
Gabriel Roldan added a comment -

ok, sorry. I wrote that under the assumption there was a single LegendURL per layer, but there is one per style. So scratch that.
Cheers,
Gabriel

Show
Gabriel Roldan added a comment - ok, sorry. I wrote that under the assumption there was a single LegendURL per layer, but there is one per style. So scratch that. Cheers, Gabriel
Hide
Permalink
Gabriel Roldan added a comment -

Bart, this is what I get for a layer with multiple styles from geoserver trunk and from 2.1.x as in here.

As you can see the xlink:href's in the Styles elements do contain the style parameter, but for the default style. I guess that is right?
The example output bellow is from a WMS 1.1.1 getcaps response, but the 1.3.0 one also contains the style parameter.
Could you confirm? how did you assess it missed the style parameter or how can I reproduce?


      <Layer queryable="1">
        <Name>topp:states</Name>
        <Title>USA Population</Title>
        <Abstract>This is some census data on the states.</Abstract>
        <KeywordList>
          <Keyword>census</Keyword>
          <Keyword>united</Keyword>
          <Keyword>boundaries</Keyword>
          <Keyword>state</Keyword>
          <Keyword>states</Keyword>
        </KeywordList>
        <SRS>EPSG:26986</SRS>
        <LatLonBoundingBox minx="-73.653" miny="34.245" maxx="-73.652" maxy="34.245"/>
        <BoundingBox SRS="EPSG:26986" minx="-5050124.8669843795" miny="-1044249.7448645392" maxx="676941.335696443" maxy="2859731.008963991"/>
        <Style>
          <Name>population</Name>
          <Title>Population in the United States</Title>
          <Abstract>A sample filter that filters the United States into three
        categories of population, drawn in different colors</Abstract>
          <LegendURL width="20" height="20">
            <Format>image/png</Format>
            <OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="http://localhost:8080/geoserver/wms?request=GetLegendGraphic&amp;format=image%2Fpng&amp;width=20&amp;height=20&amp;layer=states"/>
          </LegendURL>
        </Style>
        <Style>
          <Name>pophatch</Name>
          <Title>Population in the United States</Title>
          <Abstract>A sample filter that filters the United States into three
        categories of population, drawn in different colors</Abstract>
          <LegendURL width="20" height="20">
            <Format>image/png</Format>
            <OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="http://localhost:8080/geoserver/wms?request=GetLegendGraphic&amp;format=image%2Fpng&amp;width=20&amp;height=20&amp;layer=states&amp;style=pophatch"/>
          </LegendURL>
        </Style>
        <Style>
          <Name>polygon</Name>
          <Title>Default Polygon</Title>
          <Abstract>A sample style that draws a polygon</Abstract>
          <LegendURL width="20" height="20">
            <Format>image/png</Format>
            <OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="http://localhost:8080/geoserver/wms?request=GetLegendGraphic&amp;format=image%2Fpng&amp;width=20&amp;height=20&amp;layer=states&amp;style=polygon"/>
          </LegendURL>
        </Style>
      </Layer>
Show
Gabriel Roldan added a comment - Bart, this is what I get for a layer with multiple styles from geoserver trunk and from 2.1.x as in here . As you can see the xlink:href's in the Styles elements do contain the style parameter, but for the default style. I guess that is right? The example output bellow is from a WMS 1.1.1 getcaps response, but the 1.3.0 one also contains the style parameter. Could you confirm? how did you assess it missed the style parameter or how can I reproduce? <Layer queryable= "1" > <Name>topp:states</Name> <Title>USA Population</Title> <Abstract>This is some census data on the states.</Abstract> <KeywordList> <Keyword>census</Keyword> <Keyword>united</Keyword> <Keyword>boundaries</Keyword> <Keyword>state</Keyword> <Keyword>states</Keyword> </KeywordList> <SRS>EPSG:26986</SRS> <LatLonBoundingBox minx= "-73.653" miny= "34.245" maxx= "-73.652" maxy= "34.245" /> <BoundingBox SRS= "EPSG:26986" minx= "-5050124.8669843795" miny= "-1044249.7448645392" maxx= "676941.335696443" maxy= "2859731.008963991" /> <Style> <Name>population</Name> <Title>Population in the United States</Title> <Abstract>A sample filter that filters the United States into three categories of population, drawn in different colors</Abstract> <LegendURL width= "20" height= "20" > <Format>image/png</Format> <OnlineResource xmlns:xlink= "http: //www.w3.org/1999/xlink" xlink:type= "simple" xlink:href= "http://localhost:8080/geoserver/wms?request=GetLegendGraphic&amp;format=image%2Fpng&amp;width=20&amp;height=20&amp;layer=states" /> </LegendURL> </Style> <Style> <Name>pophatch</Name> <Title>Population in the United States</Title> <Abstract>A sample filter that filters the United States into three categories of population, drawn in different colors</Abstract> <LegendURL width= "20" height= "20" > <Format>image/png</Format> <OnlineResource xmlns:xlink= "http: //www.w3.org/1999/xlink" xlink:type= "simple" xlink:href= "http://localhost:8080/geoserver/wms?request=GetLegendGraphic&amp;format=image%2Fpng&amp;width=20&amp;height=20&amp;layer=states&amp;style=pophatch" /> </LegendURL> </Style> <Style> <Name>polygon</Name> <Title>Default Polygon</Title> <Abstract>A sample style that draws a polygon</Abstract> <LegendURL width= "20" height= "20" > <Format>image/png</Format> <OnlineResource xmlns:xlink= "http: //www.w3.org/1999/xlink" xlink:type= "simple" xlink:href= "http://localhost:8080/geoserver/wms?request=GetLegendGraphic&amp;format=image%2Fpng&amp;width=20&amp;height=20&amp;layer=states&amp;style=polygon" /> </LegendURL> </Style> </Layer>
Hide
Permalink
Bart van den Eijnden added a comment -

Hmm, I was testing with the latest Suite (2.4.3). So maybe this was fixed somewhere in between?

Show
Bart van den Eijnden added a comment - Hmm, I was testing with the latest Suite (2.4.3). So maybe this was fixed somewhere in between?
Hide
Permalink
Bart van den Eijnden added a comment -

Retested, and even in the Suite it's working fine. I must have mislooked, probably since the first LegendURL misses style but that's no problem as it's always the default.

Or maybe I was mistaken about missing workspace parameter but that's not really INSPIRE related:
http://projects.opengeo.org/suite/ticket/1396

Sorry about the confusion.

Show
Bart van den Eijnden added a comment - Retested, and even in the Suite it's working fine. I must have mislooked, probably since the first LegendURL misses style but that's no problem as it's always the default. Or maybe I was mistaken about missing workspace parameter but that's not really INSPIRE related: http://projects.opengeo.org/suite/ticket/1396 Sorry about the confusion.
Hide
Permalink
Bart van den Eijnden added a comment -

Works fine, I must have misinterpreted at the time.

Show
Bart van den Eijnden added a comment - Works fine, I must have misinterpreted at the time.
Hide
Permalink
Gabriel Roldan added a comment -

ok then, closing.

Show
Gabriel Roldan added a comment - ok then, closing.

People

  • Assignee:
    Gabriel Roldan
    Reporter:
    Bart van den Eijnden
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: